Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openjdk: download from mercurial repository to GitHub #102418

Merged
merged 1 commit into from Nov 17, 2020
Merged

openjdk: download from mercurial repository to GitHub #102418

merged 1 commit into from Nov 17, 2020

Conversation

asbachb
Copy link
Contributor

@asbachb asbachb commented Nov 2, 2020

Reasons:

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from edwtjo November 2, 2020 02:21
@asbachb
openjdk: switch from mercurial repository to GitHub
aefda81 
Reasons:
* openjdk is migrating to GitHub (https://openjdk.java.net/jeps/369)
* GitHub provides faster download speed that mercurial
@asbachb
Copy link
Contributor Author

asbachb commented Nov 4, 2020

/marvin opt-in
/status needs_reviewer

@marvin-mk2 marvin-mk2 bot added the marvin label Nov 4, 2020
@marvin-mk2
Copy link

marvin-mk2 bot commented Nov 4, 2020

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

@asbachb
Copy link
Contributor Author

asbachb commented Nov 6, 2020

/cc @NeQuissimus

@marvin-mk2
Copy link

marvin-mk2 bot commented Nov 9, 2020

Reminder: Please review!

This Pull Request is awaiting review. If you are the assigned reviewer, please have a look. Try to find another reviewer if necessary. If you can't, please say so. If the status is not accurate, please change it. If nothing happens, this PR will be put back in the needs_reviewer queue in one day.

@gebner
Copy link
Member

gebner commented Nov 9, 2020

LGTM, but you should probably migrate the other openjdk versions (8, 12, 13, 14) as well. And then change the target branch to staging because that causes a lot of rebuilds.

@asbachb
Copy link
Contributor Author

asbachb commented Nov 9, 2020

I'm going to add the other files to this PR. Only Java 8 development stayed in mercurial. There're mirrors by AdoptOpenjdk but I wonder if we should use this for building upstream openjdk package.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/hash-mismatch-building-jre-on-release-20-09/9898/11

@basvandijk
Copy link
Member

@asbachb

... Only Java 8 development stayed in mercurial.

I do see they have a tag for jdk8-b10: https://github.com/openjdk/jdk/tree/jdk8-b10. Can't we use that for openjdk-8?

@asbachb
Copy link
Contributor Author

asbachb commented Nov 13, 2020

@basvandijk from my understanding the repository contains code produced during intial development of first java 8 release. So I don't think that tag you mentioned reflects the current state nixpkgs is shipping now.

@marvin-mk2
Copy link

marvin-mk2 bot commented Nov 16, 2020

Reminder: Please review!

This Pull Request is awaiting review. If you are the assigned reviewer, please have a look. Try to find another reviewer if necessary. If you can't, please say so. If the status is not accurate, please change it. If nothing happens, this PR will be put back in the needs_reviewer queue in one day.

@asbachb
Copy link
Contributor Author

asbachb commented Nov 17, 2020

I'd suggest to merge this change for now and postpone the decision if we should migrate the others repo too after that topic gains some more traction: https://discourse.nixos.org/t/retirement-of-old-openjdk-releases/9929

@NeQuissimus NeQuissimus merged commit 01816a4 into NixOS:master Nov 17, 2020
@asbachb asbachb deleted the openjdk11-from-github branch November 17, 2020 01:58
@bhipple
Copy link
Contributor

bhipple commented Nov 18, 2020

Can you backport to 20.09 too, please?

NeQuissimus added a commit that referenced this pull request Nov 18, 2020
@NeQuissimus
Merge pull request #102418 from asbachb/openjdk11-from-github
2ce2f5a 
openjdk: download from mercurial repository to GitHub
(cherry picked from commit 01816a4)
@NeQuissimus
Copy link
Member

2ce2f5a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NeQuissimus NeQuissimus NeQuissimus approved these changes

@bhipple bhipple bhipple approved these changes

@edwtjo edwtjo Awaiting requested review from edwtjo

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 101-500 11.by: package-maintainer awaiting_reviewer marvin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@asbachb @gebner @nixos-discourse @basvandijk @bhipple @NeQuissimus