Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unarj: remove (broken since 2016, insecure since 2015) #102419

Merged
merged 1 commit into from Nov 2, 2020
Merged

unarj: remove (broken since 2016, insecure since 2015) #102419

merged 1 commit into from Nov 2, 2020

Conversation

freezeboy
Copy link
Contributor

Motivation for this change

Package not updated upstream since ages, with CVE since 2015, and marked broken here since 2016, a good candidate for removal

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

wamserma
wamserma approved these changes Nov 2, 2020
View reviewed changes
Copy link
Member

@wamserma wamserma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-shell -p nixpkgs-review --run "nixpkgs-review pr 102419" came out fine.

@ajs124 ajs124 merged commit b76c51f into NixOS:master Nov 2, 2020
@freezeboy freezeboy deleted the remove-unarj branch November 2, 2020 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wamserma wamserma wamserma approved these changes

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@freezeboy @wamserma @SuperSandro2000 @ajs124