Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backintime-qt4: unbreak #102417

Merged
merged 2 commits into from Nov 3, 2020
Merged

backintime-qt4: unbreak #102417

merged 2 commits into from Nov 3, 2020

Conversation

freezeboy
Copy link
Contributor

@freezeboy freezeboy commented Nov 2, 2020

Motivation for this change

Derivation marked broken but in fact works as expected

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@veprbl
Copy link
Member

veprbl commented Nov 2, 2020

You need to restore the meta attribute to compile things on hydra. I suggest replacing your commit with a complete revert of 119570c. You would also need to patch the build system to not try to write to /nix/store (see commit message for the original commit)

@freezeboy
Copy link
Contributor Author

ok for the meta flag, but I compiled my version and it didn't try to write to /nix/store

@veprbl
Copy link
Member

veprbl commented Nov 2, 2020

cc @mguentner

@veprbl
Copy link
Member

veprbl commented Nov 2, 2020

I don't see any changes [1] since it was marked broken, so why would it be fixed

[1] https://github.com/NixOS/nixpkgs/commits/master/pkgs/applications/networking/sync/backintime

@veprbl
Copy link
Member

veprbl commented Nov 2, 2020

I see following in the build log:

#install dbus conf
install -d /nix/store/iinzv04gsbwd8kgil9d0kk0jbv4hgxs1-backintime-qt4-1.1.24/../etc/dbus-1/system.d
install --mode=644 net.launchpad.backintime.serviceHelper.conf /nix/store/iinzv04gsbwd8kgil9d0kk0jbv4hgxs1-backintime-qt4-1.1.24/../etc/dbus-1/system.d

@veprbl
Copy link
Member

veprbl commented Nov 2, 2020

Also

substituteStream(): WARNING: pattern '="/usr/share' doesn't match anything in file '/nix/store/iinzv04gsbwd8kgil9d0kk0jbv4hgxs1-backintime-qt4-1.1.24/bin/backintime-qt4'

@freezeboy
Copy link
Contributor Author

true for the substitute I can remove it
but the install are ... in $out, so what is the problem?

@veprbl
Copy link
Member

veprbl commented Nov 2, 2020 via email

@freezeboy
Copy link
Contributor Author

Ok, I understand, it would mean add the new branch 1.2 maybe

@freezeboy
Copy link
Contributor Author

Updated to 1.2.1 and qt5, currently, there is a problem running the qt5 app, it complains on a missing QPA plugin:

Back In Time
Version: 1.2.1

Back In Time comes with ABSOLUTELY NO WARRANTY.
This is free software, and you are welcome to redistribute it
under certain conditions; type `backintime --license' for details.

qt.qpa.plugin: Could not load the Qt platform plugin "xcb" in "" even though it was found.
This application failed to start because no Qt platform plugin could be initialized. Reinstalling the application may fix this problem.

Available platform plugins are: wayland-egl, wayland, wayland-xcomposite-egl, wayland-xcomposite-glx, eglfs, linuxfb, minimal, minimalegl, offscreen, vnc, xcb, wayland-org.kde.kwin.qpa.

/nix/store/9rsxqq9n3rkcd3x8828a106d0ngvipb5-backintime-qt5-1.2.1/bin/.backintime-qt-wrapped: line 31: 22774 Aborted                 (core dumped) python3 -Es ${APP_PATH}/app.py "$@"

@veprbl
Copy link
Member

veprbl commented Nov 2, 2020

You might need to add an explicit wrapQtAppsHook to fix the missing Qt plugin problem

@veprbl
Copy link
Member

veprbl commented Nov 2, 2020

I meant not the hook, but an explicit call to wrapQtApp https://nixos.org/manual/nixpkgs/stable/#sec-language-qt

@veprbl veprbl force-pushed the unbreak-backintime-qt4 branch 4 times, most recently from 175cf12 to 9050249 Compare November 3, 2020 00:06
@veprbl veprbl force-pushed the unbreak-backintime-qt4 branch 3 times, most recently from 26b2971 to 30d16b2 Compare November 3, 2020 01:08
Co-authored-by: Dmitry Kalinkin <dmitry.kalinkin@gmail.com>
@freezeboy
Copy link
Contributor Author

@veprbl I dont see the changes from your fore-pushed, were they rebased commits ?

@veprbl
Copy link
Member

veprbl commented Nov 3, 2020

@freezeboy Sorry, let me document what I've changed:

  • added a missing space in 3d39d25#diff-189f4e80141b1b016da37c29f47a856298323b67a906b47c5359a38c0f6c4e21R4
  • renamed file from qt5.nix to qt.nix
  • changed value of the name attribute from backintime-qt5 to backintime-qt so that it matches the name of the package in all-packages.nix
  • replaced qt5.callPackage with libsForQt5.callPackage
  • replaced substituteInPlace configure --replace "/.." "" with substituteInPlace configure --replace '"/../etc' '"/etc' to prevent accidental substitutes

@veprbl veprbl merged commit 00e30c9 into NixOS:master Nov 3, 2020
@freezeboy freezeboy deleted the unbreak-backintime-qt4 branch November 3, 2020 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants