New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
backintime-qt4: unbreak #102417
backintime-qt4: unbreak #102417
Conversation
You need to restore the |
ok for the meta flag, but I compiled my version and it didn't try to write to |
cc @mguentner |
I don't see any changes [1] since it was marked broken, so why would it be fixed [1] https://github.com/NixOS/nixpkgs/commits/master/pkgs/applications/networking/sync/backintime |
I see following in the build log:
|
Also
|
true for the substitute I can remove it |
On Nov 1, 2020, at 10:57 PM, freezeboy ***@***.***> wrote:
true for the substitute I can remove it
but the install are ... in $out, so what is the problem?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.
/nix/store/etc/dbus... is a path pointing inside the store but should not be valid to use. This may work poorly for builds without sandboxing. I’m also not sure how this doesn’t fail in the sandboxed build.
On the other note, if backintime-common is not usable without backintime-qt4, we could delete them as broken.
|
2773dde
to
3913328
Compare
Ok, I understand, it would mean add the new branch 1.2 maybe |
3913328
to
831d647
Compare
Updated to 1.2.1 and qt5, currently, there is a problem running the qt5 app, it complains on a missing QPA plugin:
|
831d647
to
b0b3aa0
Compare
You might need to add an explicit |
I meant not the hook, but an explicit call to |
b0b3aa0
to
3d39d25
Compare
175cf12
to
9050249
Compare
26b2971
to
30d16b2
Compare
Co-authored-by: Dmitry Kalinkin <dmitry.kalinkin@gmail.com>
30d16b2
to
bbc8a26
Compare
@veprbl I dont see the changes from your fore-pushed, were they rebased commits ? |
@freezeboy Sorry, let me document what I've changed:
|
Motivation for this change
Derivation marked broken but in fact works as expected
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)