Skip to content

liquidwar5: 5.6.4 -> 5.6.5, unbreak #102416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 2, 2020
Merged

liquidwar5: 5.6.4 -> 5.6.5, unbreak #102416

merged 1 commit into from
Nov 2, 2020
+3 −4

Conversation

freezeboy
Copy link
Contributor

@freezeboy freezeboy commented Nov 2, 2020 •
edited
Loading

Motivation for this change

Wanting to unbreak this package, I just had to update to latest patch

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@freezeboy
liquidwar5: 5.6.4 -> 5.6.5, unbreak

Verified

This commit was signed with the committer’s verified signature. The key has expired.
mweinelt Martin Weinelt
GPG key ID: BD4AA0528F63F17E
Expired
Verified
Learn about vigilant mode
0e17599
@ofborg ofborg bot requested a review from 7c6f434c November 2, 2020 02:23
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Nov 2, 2020
@7c6f434c
Copy link
Member

7c6f434c commented Nov 2, 2020

Oh, it's alive! Thanks.

@7c6f434c 7c6f434c merged commit 5db46fe into NixOS:master Nov 2, 2020
@freezeboy freezeboy deleted the unbreak-liquidwar5 branch November 2, 2020 11:59
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 102416 run on x86_64-linux 1

1 package built:
  • liquidwar5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@7c6f434c 7c6f434c

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@freezeboy @7c6f434c @SuperSandro2000