Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

intel-media-sdk: 20.2.1 -> 20.3.1 #102485

Merged
merged 1 commit into from Nov 2, 2020
Merged

intel-media-sdk: 20.2.1 -> 20.3.1 #102485

merged 1 commit into from Nov 2, 2020

Conversation

IvarWithoutBones
Copy link
Member

Motivation for this change

Switched to fetchFromGitHub as well, which #102471 does not do.

Closes: #102471

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from midchildan November 2, 2020 13:53
midchildan
midchildan approved these changes Nov 2, 2020
View reviewed changes
Copy link
Member

@midchildan midchildan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with ffmpeg on NixOS.

danieldk
danieldk approved these changes Nov 2, 2020
View reviewed changes
Copy link
Contributor

@danieldk danieldk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 102485 1

2 packages marked as broken and skipped:
  • python37Packages.baselines
  • python37Packages.rl-coach
29 packages built:
  • MIDIVisualizer
  • ffmpeg-full
  • handbrake
  • hydron
  • intel-media-sdk
  • libsForQt5.kdenlive (kdeApplications.kdenlive ,libsForQt515.kdenlive)
  • libsForQt512.kdenlive
  • libsForQt514.kdenlive
  • liquidsoap
  • manim
  • olive-editor
  • printrun
  • python27Packages.pydub
  • python27Packages.pyglet
  • python27Packages.pytmx
  • python37Packages.gym
  • python37Packages.moderngl-window
  • python37Packages.pydub
  • python37Packages.pyglet
  • python37Packages.pytmx
  • python37Packages.roboschool
  • python38Packages.gym
  • python38Packages.moderngl-window
  • python38Packages.pydub
  • python38Packages.pyglet
  • python38Packages.pytmx
  • python38Packages.roboschool
  • soundkonverter
  • webcamoid

@danieldk danieldk merged commit 8dc3b02 into NixOS:master Nov 2, 2020
@IvarWithoutBones IvarWithoutBones deleted the intel-media-sdk-20.3.1 branch November 2, 2020 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieldk danieldk danieldk approved these changes

@midchildan midchildan midchildan approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@IvarWithoutBones @danieldk @midchildan