Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

telepathy-idle: 0.2.0 → 0.2.2 #102449

Closed
wants to merge 1 commit into from

Conversation

jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Nov 2, 2020

Motivation for this change
  • Update (switches to Meson and Python 3)
    https://github.com/TelepathyIM/telepathy-idle/blob/telepathy-idle-0.2.2/NEWS#L1-L38
  • Enable tests
    • Had to disable twisted since two of those are failing on internal timeout.
  • Move build time dependencies to nativeBuildInputs.
  • Use pkg-config instead of pkgconfig alias
  • Format the expression
  • Correct the license (based on source code comments, some files are 2.1-only, others 2.1-or later).

Does not build without TelepathyIM/telepathy-idle#10

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jtojnar jtojnar marked this pull request as draft November 2, 2020 08:39
* Update (switches to Meson and Python 3)
  https://github.com/TelepathyIM/telepathy-idle/blob/telepathy-idle-0.2.2/NEWS#L1-L38
* Enable tests
  * Had to disable twisted since two of those are failing on internal timeout.
* Move build time dependencies to nativeBuildInputs.
* Use pkg-config instead of pkgconfig alias
* Format the expression
* Correct the license (based on source code comments, some files are 2.1-only, others 2.1-or later).
@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Nov 2, 2020

Result of nixpkgs-review pr 102449 run on x86_64-linux 1

2 packages failed to build:
  • gnome3.polari
  • telepathy-idle

telepathy

unpacking sources
unpacking source archive /nix/store/f9pbrxgzcvv4xf53vjzpyrsl8k3zkhvf-telepathy-idle-0.2.2.tar.gz
source root is telepathy-idle-0.2.2
setting SOURCE_DATE_EPOCH to timestamp 1604246367 of file telepathy-idle-0.2.2/ChangeLog
patching sources
configuring
meson flags: --buildtype=plain         --libdir=/nix/store/5sny15sfa3sgv1p2bx9sbkqk9x99cksp-telepathy-idle-0.2.2/lib --libexecdir=/nix/store/5sny15sfa3sgv1p2bx9sbkqk9x99cksp-telepathy-idle-0.2.2/libexec         --bindir=/nix/store/5sny15sfa3sgv1p2bx9sbkqk9x99cksp-telepathy-idle-0.2.2/bin --sbindir=/nix/store/5sny15sfa3sgv1p2bx9sbkqk9x99cksp-telepathy-idle-0.2.2/sbin         --includedir=/nix/store/5sny15sfa3sgv1p2bx9sbkqk9x99cksp-telepathy-idle-0.2.2/include         --mandir=/nix/store/5sny15sfa3sgv1p2bx9sbkqk9x99cksp-telepathy-idle-0.2.2/share/man --infodir=/nix/store/5sny15sfa3sgv1p2bx9sbkqk9x99cksp-telepathy-idle-0.2.2/share/info         --localedir=/nix/store/5sny15sfa3sgv1p2bx9sbkqk9x99cksp-telepathy-idle-0.2.2/share/locale         -Dauto_features=enabled         -Dwrap_mode=nodownload         --prefix=/nix/store/5sny15sfa3sgv1p2bx9sbkqk9x99cksp-telepathy-idle-0.2.2 -Dtwisted_tests=false

ERROR: Neither directory contains a build file meson.build.

@jtojnar
Copy link
Contributor Author

jtojnar commented Nov 2, 2020

Yes, the files are missing, I opened TelepathyIM/telepathy-idle#10

@stale
Copy link

stale bot commented Jul 20, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 20, 2021
@NickCao
Copy link
Member

NickCao commented Jan 26, 2023

superseded by later updates.

@NickCao NickCao closed this Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.status: merge conflict 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants