Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.09] python3Packages.google_cloud_pubsub: disable tests #102409

Merged
merged 1 commit into from Nov 2, 2020
Merged

[20.09] python3Packages.google_cloud_pubsub: disable tests #102409

merged 1 commit into from Nov 2, 2020

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Nov 2, 2020 •
edited

Motivation for this change

backport #102403

tests fail due to file handle issues, then just loops
in an invalid state until timing out on hydra

https://hydra.nixos.org/build/129081889
(cherry picked from commit 9d5b01e)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jonringer
python3Packages.google_cloud_pubsub: disable tests
5a64e44 
tests fail due to file handle issues, then just loops
in an invalid state until timing out on hydra

https://hydra.nixos.org/build/129081889
(cherry picked from commit 9d5b01e)
@jonringer jonringer requested a review from FRidh as a code owner November 2, 2020 00:35
@jonringer jonringer changed the title python3Packages.google_cloud_pubsub: disable tests [20.09] python3Packages.google_cloud_pubsub: disable tests Nov 2, 2020
@ofborg ofborg bot requested a review from costrouc November 2, 2020 00:46
@jonringer jonringer merged commit ef3d691 into NixOS:release-20.09 Nov 2, 2020
@jonringer jonringer deleted the backport-pubsub branch November 2, 2020 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh FRidh is a code owner

@costrouc costrouc Awaiting requested review from costrouc

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@jonringer