python3Packages.tsfresh: init at 0.17.0 #102455
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Result of 2 packages failed to build:
|
|
logs |
|
@SuperSandro2000 it looks like the problem comes from |
sikmir
reviewed
Nov 16, 2020
|
Fails to build on darwin: |
|
Result of 2 packages built:
|
jonringer
reviewed
Nov 24, 2020
Comment on lines
40
to
44
| ] ++ ( | ||
| stdenv.lib.optional | ||
| stdenv.isDarwin | ||
| "--ignore=tests/units/utilities/test_distribution.py" | ||
| ); |
There was a problem hiding this comment.
my preference
Suggested change
| ] ++ ( | |
| stdenv.lib.optional | |
| stdenv.isDarwin | |
| "--ignore=tests/units/utilities/test_distribution.py" | |
| ); | |
| ] ++ stdenv.lib.optionals stdenv.isDarwin [ | |
| "--ignore=tests/units/utilities/test_distribution.py" | |
| ]; |
SuperSandro2000
requested changes
Jan 18, 2021
| distributed | ||
| ]; | ||
|
|
||
| meta = with stdenv.lib; { |
There was a problem hiding this comment.
Suggested change
| meta = with stdenv.lib; { | |
| meta = with lib; { |
|
This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch). Result of 2 packages built:
|
|
I marked this as stale due to inactivity. → More info |
stale
bot
added
the
2.status: stale
SuperSandro2000
requested changes
Aug 25, 2021
| homepage = "https://github.com/blue-yonder/tsfresh"; | ||
| license = licenses.mit; | ||
| maintainers = with maintainers; [ evax ]; | ||
| platforms = platforms.unix; |
There was a problem hiding this comment.
Suggested change
| platforms = platforms.unix; |
We no longer set this for buildPythonPackage except if it is not unix.
Comment on lines
+38
to
+43
| pytestFlagsArray = [ | ||
| "tests/" | ||
| "--ignore=tests/integrations" | ||
| ] ++ lib.optionals stdenv.isDarwin [ | ||
| "--ignore=tests/units/utilities/test_distribution.py" | ||
| ]; |
There was a problem hiding this comment.
Please use the new pytestCheckHook flags.
|
|
||
| checkInputs = [ | ||
| pytestCheckHook | ||
| pytestcov |
There was a problem hiding this comment.
Suggested change
| pytestcov |
stale
bot
removed
2.status: stale
|
I marked this as stale due to inactivity. → More info |
stale
bot
added
the
2.status: stale
|
Closing due to inactivity from author. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Time Series Feature extraction based on scalable hypothesis tests
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)