python3Packages.gcsfs: init at 0.7.1 #102473
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evax
force-pushed
the
gcsfs-0.7.1
branch
2 times, most recently
from
ace4449
to
3bfd1c2
Compare
|
Result of 2 packages built:
|
|
Result of 2 packages built:
|
SuperSandro2000
requested changes
Nov 25, 2020
Comment on lines
25
to
27
| pythonImportsCheck = [ | ||
| "gcsfs" | ||
| ]; |
There was a problem hiding this comment.
Suggested change
| pythonImportsCheck = [ | |
| "gcsfs" | |
| ]; | |
| pythonImportsCheck = [ "gcsfs" ]; |
nitpick
| homepage = "https://github.com/dask/gcsfs"; | ||
| license = licenses.bsd3; | ||
| maintainers = with maintainers; [ evax ]; | ||
| platforms = platforms.all; |
There was a problem hiding this comment.
This is already set by buildPythonPackage.
|
Closing this as it's been merged in #120173 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Pythonic file-system for Google Cloud Storage
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)