Skip to content

vim: Get rid of Python 2 dependency #102472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 11, 2020
Merged

vim: Get rid of Python 2 dependency #102472

merged 1 commit into from
Nov 11, 2020
+12 −8

Conversation

dasJ
Copy link
Member

@dasJ dasJ commented Nov 2, 2020 •
edited
Loading

Motivation for this change

Python 2 is unsupported.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after) (607534224 → 649524120)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: vim 8.has: changelog 8.has: documentation This PR adds or changes documentation labels Nov 2, 2020
@dasJ
Copy link
Member Author

dasJ commented Nov 2, 2020 •
edited
Loading

Result of nixpkgs-review pr 102472 1 on Darwin

1 package built:
  • vimHugeX

@ofborg ofborg bot requested a review from equirosa November 2, 2020 11:44
@omasanori
Copy link
Contributor

Result of nixpkgs-review pr 102472 1

1 package blacklisted:
  • tests.nixos-functions.nixos-test
2 packages built:
  • vimHugeX (vim_configurable)
  • vimacs

omasanori
omasanori approved these changes Nov 2, 2020
View reviewed changes
Copy link
Contributor

@omasanori omasanori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built and tested on Ubuntu 20.04 LTS on WSL2, launched vim and vimacs, did some edit. Confirmed that vim_configurable does not depend on Python 2 by nix-tree.

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 102472 run on x86_64-darwin 1

1 package built:
  • vimHugeX (vim_configurable)

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 102472 run on x86_64-linux 1

1 package blacklisted:
  • tests.nixos-functions.nixos-test
2 packages built:
  • vimHugeX (vim_configurable)
  • vimacs

@dasJ dasJ force-pushed the feat/vim-python3 branch 2 times, most recently from 7b27984 to b0c62f8 Compare November 3, 2020 19:21
equirosa
equirosa approved these changes Nov 3, 2020
View reviewed changes
Copy link
Contributor

@equirosa equirosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@dasJ
vim: Get rid of Python 2 dependency

Verified

This commit was signed with the committer’s verified signature.
renovate-bot Mend Renovate
GPG key ID: 81C63AE1C224182B
Verified
Learn about vigilant mode
576a928
@dasJ dasJ force-pushed the feat/vim-python3 branch from b0c62f8 to 576a928 Compare November 9, 2020 12:02
@ofborg ofborg bot requested a review from equirosa November 9, 2020 12:30
@dasJ dasJ requested review from danieldk, FRidh and LnL7 November 10, 2020 21:02
@danieldk
Copy link
Contributor

Merging this:

  • Python 2 is not supported anymore.
  • Several other distributions have already switched (e.g. Fedora and Debian).
  • One of the derivation's maintainers approved.
  • Seems to work fine.

@danieldk danieldk merged commit 3497b75 into NixOS:master Nov 11, 2020
@dasJ dasJ deleted the feat/vim-python3 branch November 11, 2020 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omasanori omasanori

@equirosa equirosa

@danieldk danieldk

@FRidh FRidh

@LnL7 LnL7

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: vim 8.has: changelog 8.has: documentation This PR adds or changes documentation 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dasJ @omasanori @SuperSandro2000 @danieldk @equirosa