Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

emacs26Packages.prolog-mode: unbreak #102411

Merged
merged 1 commit into from Nov 25, 2020
Merged

emacs26Packages.prolog-mode: unbreak #102411

merged 1 commit into from Nov 25, 2020

Conversation

freezeboy
Copy link
Contributor

@freezeboy freezeboy commented Nov 2, 2020 •
edited

Unfortunately this package doesn't contain the version number in the URL
so it might break easily again, but it is just a matter of updating the
sha256

Motivation for this change

Update package: beware it will happen again as the URL of the source doesn't contain the version of the package

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@freezeboy
emacs26Packages.prolog-mode: unbreak
6e386e1 
Unfortunately this package doesn't contain the version number in the URL
so it might break easily again, but it is just a matter of updating the
sha256
@SuperSandro2000
Copy link
Member

Would it be an option to request version numbers upstream?

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/272

@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Nov 25, 2020 •
edited

Result of nixpkgs-review pr 102411 run on x86_64-linux 1

Manually building succeeds.

@SuperSandro2000 SuperSandro2000 merged commit 13da973 into NixOS:master Nov 25, 2020
@freezeboy freezeboy deleted the unbreak-prolog-mode branch November 25, 2020 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adisbladis adisbladis Awaiting requested review from adisbladis

Assignees
No one assigned
Labels
6.topic: emacs 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@freezeboy @SuperSandro2000 @nixos-discourse