Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sonobuoy: Fixes wrong "v" behaviour #102433

Merged
merged 1 commit into from Nov 4, 2020
Merged

sonobuoy: Fixes wrong "v" behaviour #102433

merged 1 commit into from Nov 4, 2020

Conversation

bryanasdev000
Copy link
Member

Motivation for this change

Adjust the generated manifests by placing the character v in the sonobuoy version, successfully pulling the image within the cluster and running smoothly.

Tested on minikube and a stage kubernetes cluster. Both quick and default tests.

Fixes #102432

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bryanasdev000
sonobuoy: Fixes wrong "v" behaviour
bfa47f6 
Adjust the generated manifests by placing the character v in the sonobuoy version, successfully pulling the image within the cluster and running smoothly.

Signed-off-by: Bryan A. S <bryanasdev000@gmail.com>
wilsonehusin
wilsonehusin approved these changes Nov 2, 2020
View reviewed changes
Copy link
Contributor

@wilsonehusin wilsonehusin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- tested locally as well.

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 102433 run on x86_64-darwin 1

1 package built:
  • sonobuoy

@FRidh FRidh merged commit 22dd82c into NixOS:master Nov 4, 2020
@bryanasdev000 bryanasdev000 deleted the package-sonobuoy-0.19.0-fix branch May 3, 2021 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saschagrunert saschagrunert saschagrunert approved these changes

@wilsonehusin wilsonehusin wilsonehusin approved these changes

@carlosdagos carlosdagos Awaiting requested review from carlosdagos

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

sonobuoy: Version has no 'v' prefix which leads to the search for a non-existent image
5 participants
@bryanasdev000 @SuperSandro2000 @saschagrunert @wilsonehusin @FRidh