Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qemu: apply patch for CVE-2020-27617 #102481

Merged
merged 1 commit into from Nov 9, 2020
Merged

qemu: apply patch for CVE-2020-27617 #102481

merged 1 commit into from Nov 9, 2020

Conversation

mweinelt
Copy link
Member

@mweinelt mweinelt commented Nov 2, 2020 •
edited

Motivation for this change

https://www.openwall.com/lists/oss-security/2020/11/02/1

An assert(3) failure issue was found in the networking helper functions of QEMU. It could occur in the eth_get_gso_type() routine, if a packet does not have a valid networking L3 protocol (ex. IPv4, IPv6) value. A guest user may use this flaw to crash the QEMU process on the host resulting in DoS scenario.

Fixes: CVE-2020-27617

FWIW: I couldn't find the patch in the qemu git tree, but instead pulled it from https://patchew.org/QEMU/20201021060550.1652896-1-ppandit@redhat.com/. The qemu net subsystem maintainer Jason Wang stated that he applied the patch as is in https://lists.nongnu.org/archive/html/qemu-devel/2020-10/msg07341.html.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mweinelt
qemu: apply patch for CVE-2020-27617
0c54b75 
An assert(3) failure issue was found in the networking helper functions of QEMU. It could occur in the eth_get_gso_type() routine, if a packet does not have a valid networking L3 protocol (ex. IPv4, IPv6) value. A guest user may use this flaw to crash the QEMU process on the host resulting in DoS scenario.

Fixes: CVE-2020-27617
@ofborg ofborg bot requested a review from edolstra November 2, 2020 13:17
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 102481 run on x86_64-linux 1

1 package built:
  • qemu

@Ma27 Ma27 merged commit 5095791 into NixOS:master Nov 9, 2020
@Ma27
Copy link
Member

Ma27 commented Nov 9, 2020

@mweinelt would you like to take care of the backport or should I do that? :)

@mweinelt
Copy link
Member Author

mweinelt commented Nov 9, 2020

I can do it in an hour or so. So if you're faster, go for it!

@mweinelt mweinelt deleted the qemu/cve-2020-27617 branch November 9, 2020 22:53
@mweinelt mweinelt mentioned this pull request Nov 9, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ma27 Ma27 Ma27 approved these changes

@edolstra edolstra Awaiting requested review from edolstra

Assignees
No one assigned
Labels
1.severity: security 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mweinelt @SuperSandro2000 @Ma27