Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deno: 1.5.0 -> 1.5.1 #102461

Merged
merged 1 commit into from Nov 3, 2020
Merged

deno: 1.5.0 -> 1.5.1 #102461

merged 1 commit into from Nov 3, 2020

Conversation

06kellyjac
Copy link
Member

Motivation for this change

Bump deno to 1.5.1

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS (x86_64)
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@06kellyjac
Copy link
Member Author

Result of nixpkgs-review pr 102461 1

1 package built:
  • deno

Copy link
Member

@stigtsp stigtsp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Built and tested OK on linux x64

Result of nixpkgs-review pr 102461 1

1 package built:
  • deno

@stigtsp stigtsp merged commit f290e0e into NixOS:master Nov 3, 2020
@06kellyjac 06kellyjac deleted the deno_1.5.1 branch November 3, 2020 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants