Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.imantics: init at 0.1.12 #102442

Merged
merged 1 commit into from Nov 26, 2020
Merged

pythonPackages.imantics: init at 0.1.12 #102442

merged 1 commit into from Nov 26, 2020

Conversation

Rakesh4G
Copy link
Contributor

@Rakesh4G Rakesh4G commented Nov 2, 2020 •
edited

Motivation for this change

pythonPackages.imantics: init at 0.1.12
Requires : #102440

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Rakesh4G Rakesh4G mentioned this pull request Nov 2, 2020
Merged
10 tasks
@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Nov 2, 2020 •
edited

You could have put that into the other PR because it is required for the other package. Also ofborg would then eval and I could test the build on darwin.

SuperSandro2000
SuperSandro2000 reviewed Nov 2, 2020
View reviewed changes
pkgs/development/python-modules/imantics/default.nix Outdated
--replace "'opencv-python>=3'," ""
'';

doCheck = False;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it not have tests? If so can you at least do an import check?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test cases are there, but they are failing. I am not having time to fix them.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a comment about that?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
doCheck = False;
# failing on NixOS
doCheck = False;

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

pkgs/development/python-modules/imantics/default.nix Show resolved Hide resolved
SuperSandro2000
SuperSandro2000 reviewed Nov 25, 2020
View reviewed changes
pkgs/development/python-modules/imantics/default.nix Outdated

doCheck = False;

meta = with stdenv.lib; {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
meta = with stdenv.lib; {
meta = with lib; {

This fixes the eval error.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not be an issue as i have imported lib on top of the package.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh sorry, I misread it. correcting

jonringer
jonringer reviewed Nov 25, 2020
View reviewed changes
pkgs/development/python-modules/imantics/default.nix Outdated
'';

# failing on NixOS
doCheck = False;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If tests are not available, then please use pythonImportsCheck to import the most important modules. This isn't as good as unit tests, but will usually give a good indication of run-time errors. Please see pythonImportsCheck documentation for more information.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 102442 run on x86_64-linux 1

1 package marked as broken and skipped:
  • python27Packages.imantics
2 packages built:
  • python37Packages.imantics
  • python38Packages.imantics

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 102442 run on x86_64-darwin 1

1 package marked as broken and skipped:
  • python27Packages.imantics
2 packages built:
  • python37Packages.imantics
  • python38Packages.imantics

@SuperSandro2000 SuperSandro2000 merged commit 437cc30 into NixOS:master Nov 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Rakesh4G @SuperSandro2000 @jonringer