haskellPackages.hindent: unbreak by fetching more recent source #101082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This update was generated by hackage2nix v2.15.5-21-g59d310e from Hackage revision commercialhaskell/all-cabal-hashes@2a9259d.
This update was generated by hackage2nix v2.15.5-22-g3b35a5f from Hackage revision commercialhaskell/all-cabal-hashes@d64cb5e.
This update was generated by hackage2nix v2.15.5-22-g3b35a5f from Hackage revision commercialhaskell/all-cabal-hashes@80ba8be.
This update was generated by hackage2nix v2.15.5-25-gc299817 from Hackage revision commercialhaskell/all-cabal-hashes@1da79df.
…aeson microaeson: Unbreak via jailbreak
With NixOS#101008, this package builds successfully and passes all tests as well.
haskellPackages.stan: Mark as not broken and enable tests
This update was generated by hackage2nix v2.15.5-25-gc299817 from Hackage revision commercialhaskell/all-cabal-hashes@19db652.
|
Yes makes sense, that's a better way. I will change this later today.
…On Tue, Oct 20, 2020, 03:01 Dennis Gosnell ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In pkgs/development/haskell-modules/configuration-common.nix
<#101082 (comment)>:
> + src = pkgs.fetchFromGitHub {
+ owner = "mihaimaruseac";
+ repo = "hindent";
+ rev = "085417feebf6f24ec211a05eee6f28c3d7cc1caf";
+ sha256 = "0336k34549ni3faz43fp5bpbgx85v6v4fjcincylwggwylfnnill";
+ };
Oh, also, is https://github.com/mihaimaruseac/hindent the new home of
hindent? The latest hackage package (
https://hackage.haskell.org/package/hindent-5.3.1) lists
https://github.com/commercialhaskell/hindent as the home...
which redirects to https://github.com/mihaimaruseac/hindent when you
click on it... Okay, ignore this question then!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#101082 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAEQNT7I6PKZ2IV5AOTK6ITSLTOPHANCNFSM4SWPCFDA>
.
|
This update was generated by hackage2nix v2.15.5-25-gc299817 from Hackage revision commercialhaskell/all-cabal-hashes@fcfa288.
markus1189
force-pushed
the
hindent-unbreak
branch
from
647e411
to
c4e09ad
Compare
ofborg
bot
added
10.rebuild-darwin: 0
10.rebuild-linux: 0
and removed
10.rebuild-darwin: 11-100
10.rebuild-linux: 11-100
labels
peti
force-pushed
the
haskell-updates
branch
2 times, most recently
from
d060d81
to
c90c206
Compare
peti
force-pushed
the
haskell-updates
branch
3 times, most recently
from
87295a3
to
e240cce
Compare
peti
requested changes
Nov 6, 2020
| @@ -630,14 +630,16 @@ self: super: { | |||
|
|
|||
| # Make elisp files available at a location where people expect it. | |||
| hindent = (overrideCabal super.hindent (drv: { | |||
| # 2020-10-19: needs MonadFail fix, see https://github.com/mihaimaruseac/hindent/issues/570 | |||
| patches = [ ./patches/hindent-monadfail.patch ]; | |||
There was a problem hiding this comment.
Please fetch that patch from Github instead of checking it into our repository.
peti
force-pushed
the
haskell-updates
branch
3 times, most recently
from
a7d0cd6
to
d1e684c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Hindent fails to build due to a missing
MonadFailinstance, which is already present at HEAD, but not yet released.There is an open issue for a release here: mihaimaruseac/hindent#570
Meanwhile, we can fix
hindentby fetching a more recent version.Also, enable the tests, because they pass.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)