Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reland "Reenable scroll-animations/element-based-offset tests" #26173

Merged
merged 1 commit into from Oct 19, 2020

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Oct 19, 2020

The patch fixes the underlying problem in the element-based-offset
tests, whereby a scroll timeline can be created before layout resulting
in a zero scroll range. This patch adds a forced layout.

Revert CL: https://chromium-review.googlesource.com/c/chromium/src/+/2483585

Bug: 1080609
Change-Id: I44c6186f535e713d49a9ce6cab4d6aa68c302889
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2484267
Reviewed-by: Xida Chen <xidachen@chromium.org>
Commit-Queue: Kevin Ellis <kevers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818480}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Chromium project.

The patch fixes the underlying problem in the element-based-offset
tests, whereby a scroll timeline can be created before layout resulting
in a zero scroll range.  This patch adds a forced layout.

Revert CL: https://chromium-review.googlesource.com/c/chromium/src/+/2483585

Bug: 1080609
Change-Id: I44c6186f535e713d49a9ce6cab4d6aa68c302889
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2484267
Reviewed-by: Xida Chen <xidachen@chromium.org>
Commit-Queue: Kevin Ellis <kevers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818480}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants