[20.09] kdeFrameworks.plasma-framework: aligned with QtQuick 2.12 #101078
Conversation
Aligned plasma-framework with qt5.12 see NixOS#98536
jonringer
force-pushed
the
fix-plasma-framework
branch
from
b65e770
to
f868c68
Compare
|
|
jonringer
changed the title
| # see https://github.com/NixOS/nixpkgs/issues/98536 | ||
| postPatch = '' | ||
| substituteInPlace src/declarativeimports/plasmaextracomponents/qml/ExpandableListItem.qml \ | ||
| --replace "import QtQuick 2.14" "import QtQuick 2.12" |
There was a problem hiding this comment.
Not really qualified to review this, but I'm pretty interested:
- Where does the 2.14 come from?
- Where does the 2.12 come from?
- Will this break on the next
libsForQt5 = libsForQt512andlibsForQt5 = libsForQt514bump? - Should this be parametrized on some
${qt5.base.version}to be more future proof?
There was a problem hiding this comment.
Where does the 2.14 come from?
It's what the upstream plasma-frameworks expects
Where does the 2.12 come from?
I got that from other applications which were working
Will this break on the next libsForQt5 = libsForQt512 and libsForQt5 = libsForQt514 bump?
This is specifically for the 20.09 release, those are unlikely to be bumped.
But it's just the version of the widget, so I don't think this will be too "harmful"
Should this be parametrized on some ${qt5.base.version} to be more future proof?
AFAIK, these are looked up at runtime, and us needing to use the 5.12 qt libraries is where this mismatch comes from. However, using a "previous" version of the widget seems to be harmless
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/go-no-go-meeting-nixos-20-09-nightingale/9169/24 |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/what-should-stable-nixos-prioritize/9646/1 |
Motivation for this change
A less invasive remedy for #98536
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)