Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

20.03 -> 20.09 bump #619

Merged
merged 25 commits into from Oct 27, 2020
Merged

20.03 -> 20.09 bump #619

merged 25 commits into from Oct 27, 2020

Conversation

garbas
Copy link
Member

@garbas garbas commented Oct 19, 2020 •
edited by jonringer

TODO

  • release announcement (highlight of the release)
  • release banner (with expiration time, eg. 1 month)
  • Add gnome flavor iso to the download page
  • check that download page links work (all ISO, EC2 images) and correct version is displayed in the header
  • check that correct manual versions are displayed for nixos and nixpkgs

closes #416
closes #628

This change is Reviewable

@garbas garbas requested a review from jonringer October 19, 2020 17:44
@garbas garbas added this to In progress in 20.09 Blockers via automation Oct 19, 2020
@github-actions
Copy link
Contributor

🚀 Deployed on https://5f8dd36e034b0e011f46bbeb--nixos-homepage.netlify.app

@github-actions
Copy link
Contributor

🚀 Deployed on https://5f8ddf79c7c5d210f76c0fec--nixos-homepage.netlify.app

20.09 Blockers automation moved this from In progress to Reviewer approved Oct 19, 2020
jonringer
jonringer approved these changes Oct 19, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Once the release announcement is done

@github-actions
Copy link
Contributor

🚀 Deployed on https://5f8f1a670da0020fb1c0834b--nixos-homepage.netlify.app

@github-actions
Copy link
Contributor

🚀 Deployed on https://5f97159e2a9d6b58af709cc8--nixos-homepage.netlify.app

@github-actions
Copy link
Contributor

🚀 Deployed on https://5f972be27356050ea238f202--nixos-homepage.netlify.app

@github-actions
Copy link
Contributor

🚀 Deployed on https://5f9734d2da0ac518f2b5010e--nixos-homepage.netlify.app

@github-actions
Copy link
Contributor

🚀 Deployed on https://5f973b71d2f7591d228404ec--nixos-homepage.netlify.app

@github-actions
Copy link
Contributor

🚀 Deployed on https://5f973e82b3fefb1e41453c5c--nixos-homepage.netlify.app

@github-actions
Copy link
Contributor

🚀 Deployed on https://5f9743de6af89d2da6517aff--nixos-homepage.netlify.app

cole-h
cole-h reviewed Oct 26, 2020
View reviewed changes
news.xml Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

🚀 Deployed on https://5f97557807d350012aad5a7f--nixos-homepage.netlify.app

20.09 Blockers automation moved this from Reviewer approved to Review in progress Oct 27, 2020
samueldr
samueldr suggested changes Oct 27, 2020
View reviewed changes
Copy link
Member

@samueldr samueldr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just in case, since I was checking the PR, I highlighted your TODO items.

Everything else looks alright at a glance.

news.xml Outdated Show resolved Hide resolved
news.xml Outdated Show resolved Hide resolved
news.xml Outdated Show resolved Hide resolved
@worldofpeace
Copy link
Contributor

@cole-h You are my number 1 angel 🤣 I'm wondering how many of this could be put back into the release notes.

@github-actions
Copy link
Contributor

🚀 Deployed on https://5f97dd35158a004bcd2e22b4--nixos-homepage.netlify.app

@github-actions
Copy link
Contributor

🚀 Deployed on https://5f97de95114ace41b1e5de88--nixos-homepage.netlify.app

@github-actions
Copy link
Contributor

🚀 Deployed on https://5f97df4e605bdc3f891c4b36--nixos-homepage.netlify.app

@worldofpeace
emoji sparkle
7fa6bb4 
hella wrong IMHO to not have at least one
@github-actions
Copy link
Contributor

🚀 Deployed on https://5f97e0f58e4c523de5bd67cd--nixos-homepage.netlify.app

@github-actions
Copy link
Contributor

🚀 Deployed on https://5f985910d6bee600e1eaaf3d--nixos-homepage.netlify.app

davidak
davidak suggested changes Oct 27, 2020
View reviewed changes
Copy link
Member

@davidak davidak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very good overall ✨

news.xml Outdated Show resolved Hide resolved
news.xml Outdated Show resolved Hide resolved
20.09 Blockers automation moved this from Reviewer approved to Review in progress Oct 27, 2020
cole-h
cole-h suggested changes Oct 27, 2020
View reviewed changes
news.xml Outdated Show resolved Hide resolved
news.xml Outdated Show resolved Hide resolved
news.xml Outdated Show resolved Hide resolved
@jonringer
Copy link
Contributor

thanks @davidak @cole-h

@github-actions
Copy link
Contributor

🚀 Deployed on https://5f986c888d313c01250edf66--nixos-homepage.netlify.app

20.09 Blockers automation moved this from Review in progress to Reviewer approved Oct 27, 2020
cole-h
cole-h approved these changes Oct 27, 2020
View reviewed changes
Copy link
Member

@cole-h cole-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's so close, I can taste it.

@jonringer
Copy link
Contributor

I think that's it folks :)

@davidak
Copy link
Member

davidak commented Oct 27, 2020

I do the same for the manual release notes now.

@jonringer
Copy link
Contributor

I do the same for the manual release notes now.

those are already merged, as they are a part of nixpkgs

@github-actions
Copy link
Contributor

🚀 Deployed on https://5f98717a522c3b00ba63c41c--nixos-homepage.netlify.app

@jonringer jonringer merged commit ef73dd4 into master Oct 27, 2020
20.09 Blockers automation moved this from Reviewer approved to Done Oct 27, 2020
@garbas garbas deleted the release-20.09 branch October 27, 2020 19:16
@davidak davidak mentioned this pull request Oct 27, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@davidak davidak davidak approved these changes

@samueldr samueldr samueldr approved these changes

@cole-h cole-h cole-h approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
20.09 Blockers
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

20.09 Release announcement Download Page: Link to GNOME ISO
6 participants
@garbas @jonringer @samueldr @worldofpeace @davidak @cole-h