Navigation Menu

Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
base: 67d2de5ffaa6
Choose a base ref
...
head repository: NixOS/nixpkgs
compare: ffac55a0da5d
Choose a head ref
  • 2 commits
  • 1 file changed
  • 1 contributor

Commits on Oct 19, 2020

  1. bazel: Fix bazel query and provide a default java toolchain 

    These are fixes for problems I ran into with:
- `bazel test //example:cpp-test`
This needed `build --host_javabase='@local_jdk//:jdk'`

- `bazel query 'deps(//example:cpp-test)'`
This needed the same flags as `build`.

Is it contentious to (partially?) configure the default java toolchain? I don't see it as much different than providing the bazel server's java.
It would continue to be configurable/overridable by overriding the flags. 

---
And a random notes from this escapade, but https://github.com/bazelbuild/bazel/blob/master/WORKSPACE#L144-L308 looks a little different from https://github.com/NixOS/nixpkgs/blob/master/pkgs/development/tools/build-managers/bazel/bazel_3/src-deps.json so one of them is probably wrong :)
    @mfarrugi @Profpatsch
    mfarrugi authored and Profpatsch committed Oct 19, 2020
    Copy the full SHA
    a360b05 View commit details
    Browse the repository at this point in the history

  2. format

    @mfarrugi @Profpatsch
    mfarrugi authored and Profpatsch committed Oct 19, 2020
    Copy the full SHA
    ffac55a View commit details
    Browse the repository at this point in the history