Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libpeas: 1.26.0 -> 1.28.0 #101079

Closed
wants to merge 1 commit into from
Closed

libpeas: 1.26.0 -> 1.28.0 #101079

wants to merge 1 commit into from

Conversation

oxzi
Copy link
Member

@oxzi oxzi commented Oct 19, 2020

Motivation for this change

Update libpeas to its latest release.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jtojnar
Copy link
Contributor

jtojnar commented Oct 19, 2020 •
edited

Thanks. This is part of #98316. It is usually better to leave major updates of GNOME stack to single big PR because often the libraries depend on bumps of other libraries on the stack.

@oxzi
Copy link
Member Author

oxzi commented Oct 19, 2020

@jtojnar: Thanks for your feedback; I overlooked this change in this PR.

@oxzi oxzi closed this Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace Awaiting requested review from worldofpeace

@jtojnar jtojnar Awaiting requested review from jtojnar

@hedning hedning Awaiting requested review from hedning

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@oxzi @jtojnar