Cookies: modernize http-state directory #26169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Letting web-platform-tests take care of rendering the result pages makes these a lot more legible.
|
Asking @miketaylr to take a look, as he's also actively poking at the cookie test suite. |
|
That would be great. There sure seem to be way too many failures. |
miketaylr
approved these changes
Oct 19, 2020
| @@ -10,14 +10,9 @@ | |||
| <script src="/resources/testharnessreport.js"></script> | |||
| <script src="resources/cookie-http-state-template.js"></script> | |||
| </head> | |||
| <body style="background:#EEE"> | |||
| <h3>Log</h3> | |||
| <div id="log" style="height:50px; overflow-y:scroll; background: #FFF"> | |||
There was a problem hiding this comment.
Thanks so much for this, this 50px style was ruining my afternoon last week.
Yes, particularly the domain and path tests are just broken. And cookie clearing for iframes doesn't work. It's on my plate to either fix or re-write everything in http-state. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Letting web-platform-tests take care of rendering the result pages makes these a lot more legible.