New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
zoom-us: add xdg_utils to PATH #100560
zoom-us: add xdg_utils to PATH #100560
Conversation
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/no-sso-in-zoom-unless-firefox-is-installed/9453/2 |
This allows Zoom to open a web browser other than Google Chrome, Firefox or Opera when xdg_utils is not installed.
e6310c8
to
d4f987f
Compare
So we are not sure if it fixes the issue? |
Honestly, I have no idea, I don't use zoom myself. I'm doing this because https://github.com/qt/qtbase/blob/871392790eafdd22521367ba485da5c10e9bb0db/src/gui/platform/unix/qgenericunixservices.cpp#L126 suggests it may help. Qt tries The error message "Unable to detect a web browser to launch" comes from Qt according to web search. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It can't hurt anything, and it does appear Qt is indeed shelling out to xdg-open
for this interaction. This may explain the SSO/Google login issues, as I have xdg-open
in my $PATH
but other users may not.
I would have tested that myself, but I don't have a way to sign in with SSO to reproduce the behavior. OTH, if someone else has SSO, uninstalling xdg_utils for the sake of testing this shouldn't be difficult. |
This allows Zoom to open a web browser other than Google Chrome,
Firefox or Opera when xdg_utils is not installed.
Motivation for this change
It may help with https://discourse.nixos.org/t/no-sso-in-zoom-unless-firefox-is-installed/9453.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)