Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perlPackages.Mojolicious: 8.58 -> 8.63 #100599

Merged
merged 1 commit into from Oct 15, 2020
Merged

perlPackages.Mojolicious: 8.58 -> 8.63 #100599

merged 1 commit into from Oct 15, 2020

Conversation

stigtsp
Copy link
Member

@stigtsp stigtsp commented Oct 15, 2020

Motivation for this change

https://github.com/mojolicious/mojo/blob/v8.63/Changes

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@stigtsp stigtsp requested a review from volth October 15, 2020 13:41
@stigtsp
Copy link
Member Author

stigtsp commented Oct 15, 2020

Result of nixpkgs-review 1

44 packages built:
  • abcde
  • convos
  • perl530Packages.JSONValidator
  • perl530Packages.LinkEmbedder
  • perl530Packages.Minion
  • perl530Packages.MinionBackendSQLite
  • perl530Packages.MinionBackendmysql
  • perl530Packages.MojoIOLoopForkCall
  • perl530Packages.MojoJWT
  • perl530Packages.MojoPg
  • perl530Packages.MojoRedis
  • perl530Packages.MojoSQLite
  • perl530Packages.Mojolicious
  • perl530Packages.MojoliciousPluginAssetPack
  • perl530Packages.MojoliciousPluginGravatar
  • perl530Packages.MojoliciousPluginMail
  • perl530Packages.MojoliciousPluginOpenAPI
  • perl530Packages.MojoliciousPluginStatus
  • perl530Packages.MojoliciousPluginTextExceptions
  • perl530Packages.MojoliciousPluginWebpack
  • perl530Packages.Mojomysql
  • perl530Packages.MusicBrainz
  • perl530Packages.OpenAPIClient
  • perl532Packages.JSONValidator
  • perl532Packages.LinkEmbedder
  • perl532Packages.Minion
  • perl532Packages.MinionBackendSQLite
  • perl532Packages.MinionBackendmysql
  • perl532Packages.MojoIOLoopForkCall
  • perl532Packages.MojoJWT
  • perl532Packages.MojoPg
  • perl532Packages.MojoRedis
  • perl532Packages.MojoSQLite
  • perl532Packages.Mojolicious
  • perl532Packages.MojoliciousPluginAssetPack
  • perl532Packages.MojoliciousPluginGravatar
  • perl532Packages.MojoliciousPluginMail
  • perl532Packages.MojoliciousPluginOpenAPI
  • perl532Packages.MojoliciousPluginStatus
  • perl532Packages.MojoliciousPluginTextExceptions
  • perl532Packages.MojoliciousPluginWebpack
  • perl532Packages.Mojomysql
  • perl532Packages.MusicBrainz
  • perl532Packages.OpenAPIClient

@stigtsp stigtsp requested a review from aanderse October 15, 2020 13:45
@stigtsp
Copy link
Member Author

stigtsp commented Oct 15, 2020 •
edited

@aanderse Can you trigger a build (to check darwin)?

@aanderse
Copy link
Member

@GrahamcOfBorg build perlPackages.Mojolicious perldevelPackages.Mojolicious

@aanderse
Copy link
Member

Oh... I think the bot might not be working with darwin right now.

@stigtsp
Copy link
Member Author

stigtsp commented Oct 15, 2020

Built and tested OK on darwin x64 (locally)

@stigtsp stigtsp merged commit 3464ccf into NixOS:master Oct 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aanderse aanderse Awaiting requested review from aanderse

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@stigtsp @aanderse