Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add quicklogic platform #504

Merged
merged 1 commit into from Oct 15, 2020
Merged

Add quicklogic platform #504

merged 1 commit into from Oct 15, 2020

Conversation

kowalewskijan
Copy link
Contributor

This PR introduces a support for QuickLogic EOS-S3 platform.

whitequark
whitequark reviewed Oct 14, 2020
View reviewed changes
Copy link
Member

@whitequark whitequark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good other than the comments, thanks for this work!

@kowalewskijan kowalewskijan mentioned this pull request Oct 14, 2020
Merged
@kowalewskijan kowalewskijan force-pushed the quicklogic branch 2 times, most recently from dc0b502 to 79dfae7 Compare October 15, 2020 08:46
@kamilrakoczy
Add quicklogic platform
91bdf18 
Signed-off-by: Kamil Rakoczy <krakoczy@antmicro.com>
Signed-off-by: Jan Kowalewski <jkowalewski@antmicro.com>
whitequark
whitequark approved these changes Oct 15, 2020
View reviewed changes
Copy link
Member

@whitequark whitequark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@whitequark whitequark merged commit 9746138 into amaranth-lang:master Oct 15, 2020
@whitequark
Copy link
Member

whitequark commented Oct 15, 2020 •
edited

Note: despite the earlier comment, EOS S3 does support SDR registers (see here), but the FOSS toolchain does not currently support them (see here). Once it does we should add SDR support, that should be pretty easy though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whitequark whitequark whitequark approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kowalewskijan @whitequark @kamilrakoczy