python3Packages.pyelftools: disable tests on Darwin #100602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
6.topic: darwin
siriobalmelli
force-pushed
the
fix/pyelftools
branch
4 times, most recently
from
f9b3cbb
to
9c5cf87
Compare
Pamplemousse
approved these changes
Oct 23, 2020
siriobalmelli
force-pushed
the
fix/pyelftools
branch
2 times, most recently
from
e6b499c
to
3910fe4
Compare
Pamplemousse
approved these changes
Oct 28, 2020
siriobalmelli
force-pushed
the
fix/pyelftools
branch
from
3910fe4
to
183ffad
Compare
Pamplemousse
approved these changes
Nov 2, 2020
af27072 broke the build on Darwin. There does not seem to be any way to sanely enable tests on Darwin. Tests initially fail because of missing 'greadelf' expected by test/run_readelf_tests.py. This is fixed by: - adding 'binutils-unwrapped' to checkInputs - hardlinking 'readelf' to 'greadelf' in a temp bin dir - exporting temp bin dir to PATH This leads to further test failures because of 'readelf' version mismatch causing output inconsistencies. See test/run_readelf_tests.py:31 for further details. Signed-off-by: Sirio Balmelli <sirio@b-ad.ch>
siriobalmelli
force-pushed
the
fix/pyelftools
branch
from
183ffad
to
080e6ca
Compare
Pamplemousse
approved these changes
Nov 6, 2020
igsha
approved these changes
Nov 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
af27072 broke the build on Darwin (see #99202)
There does not seem to be any way to sanely enable tests on Darwin.
Tests initially fail because of missing 'greadelf'
expected by test/run_readelf_tests.py.
This is fixed by:
This leads to further test failures because of 'readelf' version mismatch
causing output inconsistencies.
See test/run_readelf_tests.py:31 for further details.
Signed-off-by: Sirio Balmelli sirio@b-ad.ch
Motivation for this change
build on Darwin
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)Ensured that relevant documentation is up to date