Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

surf: 2.0 -> unstable-2019-02-08 #101430

Merged
merged 1 commit into from Nov 26, 2020
Merged

surf: 2.0 -> unstable-2019-02-08 #101430

merged 1 commit into from Nov 26, 2020

Conversation

SuperSandro2000
Copy link
Member

Motivation for this change

Closes #81629

@alexherbo2

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SuperSandro2000 SuperSandro2000 mentioned this pull request Oct 23, 2020
Closed
@ofborg ofborg bot requested a review from joachifm October 23, 2020 00:15
@alexherbo2
Copy link
Contributor

@SuperSandro2000 Can you update the description to replace Surf → surf and WebKit/GTK → WebKitGTK?

@SuperSandro2000
Copy link
Member Author

@SuperSandro2000 Can you update the description to replace Surf → surf and WebKit/GTK → WebKitGTK?

Changed that.

@SuperSandro2000
Copy link
Member Author

Result of nixpkgs-review pr 101430 1

2 packages built:
  • surf (surf-webkit2)
  • surf-display

@SuperSandro2000
Copy link
Member Author

Result of nixpkgs-review pr 101430 run on x86_64-linux 1

2 packages built:
  • surf (surf-webkit2)
  • surf-display

@SuperSandro2000
Copy link
Member Author

Result of nixpkgs-review pr 101430 run on x86_64-darwin 1

1 package marked as broken and skipped:
  • surf

@SuperSandro2000 SuperSandro2000 merged commit 1180d54 into NixOS:master Nov 26, 2020
@SuperSandro2000 SuperSandro2000 deleted the 81629-surf branch November 26, 2020 23:36
@SuperSandro2000 SuperSandro2000 changed the title surf: 2.0 -> 2019-02-08-unstable surf: 2.0 -> unstable-2019-02-08 Nov 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sikmir sikmir sikmir left review comments

@joachifm joachifm Awaiting requested review from joachifm

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update surf package
3 participants
@SuperSandro2000 @alexherbo2 @sikmir