Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

igmpproxy: init at version 0.2.1 #101455

Merged
merged 1 commit into from Nov 27, 2020
Merged

igmpproxy: init at version 0.2.1 #101455

merged 1 commit into from Nov 27, 2020

Conversation

sdier
Copy link
Contributor

@sdier sdier commented Oct 23, 2020

Motivation for this change

I plan to add a nixos module in a future pull request.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 101455 1

1 package built:
  • igmpproxy

@sdier
Copy link
Contributor Author

sdier commented Oct 23, 2020 •
edited

I have tested this on my router (the ISP I use has multicast services) and the binary works with this module that I'll send in a following PR:
https://github.com/sdier/nixpkgs/blob/igmpproxy-module/nixos/modules/services/networking/igmpproxy.nix

@SuperSandro2000 SuperSandro2000 merged commit 1754f25 into NixOS:master Nov 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@delroth delroth delroth approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sdier @SuperSandro2000 @delroth