Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[20.09] pythonPackages.pyotp: disable on Python27 #101439

Merged
merged 1 commit into from Oct 23, 2020

Conversation

IvarWithoutBones
Copy link
Member

(cherry picked from commit 7a34808)

Motivation for this change

I got the backport for this (#100025) merged before it got merged to master, and because of that it missed a few fixes from review comments (oops).

ZHF: #97479
PR to master: #100023

cc @mweinelt

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mweinelt
Copy link
Member

Result of nixpkgs-review pr 101439 1

3 packages built:
  • home-assistant
  • python37Packages.pyotp
  • python38Packages.pyotp

@mweinelt mweinelt merged commit 70b255f into NixOS:release-20.09 Oct 23, 2020
@IvarWithoutBones IvarWithoutBones deleted the backport-pyotp branch October 23, 2020 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants