Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.transformers: 3.3.1 -> 3.4.0 #101443

Merged
merged 3 commits into from Oct 28, 2020
Merged

python3Packages.transformers: 3.3.1 -> 3.4.0 #101443

merged 3 commits into from Oct 28, 2020

Conversation

danieldk
Copy link
Contributor

Motivation for this change

Update transformers and its tokenizers dependency.

Changelog:

https://github.com/huggingface/transformers/releases/tag/v3.4.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@danieldk
python3Packages.setuptools-rust: init at 0.11.3
3f47cc1
@danieldk
python3Packages.tokenizers: 0.8.1 -> 0.9.2
50531c7 
Changelog:

https://github.com/huggingface/tokenizers/releases/tag/python-v0.9.0
https://github.com/huggingface/tokenizers/releases/tag/python-v0.9.1
https://github.com/huggingface/tokenizers/releases/tag/python-v0.9.2

Changes in the derivation:

* Tokenizers uses a newer version of pyo3 that does not require Rust
  nightly anymore. So, we do not have to use any cheat codes anymore.
* Tokenizers is now a mixed Rust/Python project. The way it is set
  up does not work with Maturin, so switch to setuptools-rust instead.
* Add additional data files needed for tests.
* Use `pytestCheckHook`.
@danieldk
python3Packages.transformers: 3.3.1 -> 3.4.0
4400731 
Changelog:

https://github.com/huggingface/transformers/releases/tag/v3.4.0
@danieldk danieldk mentioned this pull request Oct 23, 2020
Closed
10 tasks
@danieldk
Copy link
Contributor Author

@ofborg build python37Packages.transformers python38Packages.transformers

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/350

jonringer
jonringer approved these changes Oct 28, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 101443 1

7 packages built:
  • python27Packages.setuptools-rust
  • python37Packages.setuptools-rust
  • python37Packages.tokenizers
  • python37Packages.transformers
  • python38Packages.setuptools-rust
  • python38Packages.tokenizers
  • python38Packages.transformers

@jonringer jonringer merged commit 05f6de9 into NixOS:master Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@danieldk @nixos-discourse @jonringer