Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

goreleaser: init at 0.132.0 #82986

Closed
wants to merge 1 commit into from
Closed

goreleaser: init at 0.132.0 #82986

wants to merge 1 commit into from

Conversation

c0deaddict
Copy link
Member

Motivation for this change

Using this package at my workplace.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from kalbasit March 20, 2020 09:36
@Emantor
Copy link
Member

Emantor commented Apr 6, 2020

I get a hash-mismatch when trying to build:

$ nix build --no-link --keep-going --option build-use-sandbox relaxed -f /home/phoenix/.cache/nixpkgs-review/pr-82986/build.nix
hash mismatch in fixed-output derivation '/nix/store/283lphykg26296pavr96gyvsm5y038lf-goreleaser-0.129.0-go-modules':
  wanted: sha256:0hlfwayhcsiknmzirv38bw9xhr2rlb34fmwx5k6yy1bz72n4hw4p
  got:    sha256:07lgw43qkmm639s6q37ipl5628bdxi9wpgf7gzwyq9xvp4f7v8g5
cannot build derivation '/nix/store/kbqngvsfax2w3r5ifpj4ki8d81wqxaxq-goreleaser-0.129.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/7blnypk8aw5r7yw22q3g5kgxi0wr59zx-env.drv': 1 dependencies couldn't be built
[1 built (1 failed), 0.0 MiB DL]
error: build of '/nix/store/7blnypk8aw5r7yw22q3g5kgxi0wr59zx-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/82986
1 package failed to build:
goreleaser

@c0deaddict c0deaddict changed the title goreleaser: init at 0.129.0 goreleaser: init at 0.132.0 Apr 20, 2020
@c0deaddict
Copy link
Member Author

Thanks for reviewing.

Strange that the hash changed, it worked before I pushed it.

A new version of goreleaser is out, i've updated the version and hashes accordingly.

@sarcasticadmin sarcasticadmin mentioned this pull request Oct 19, 2020
Merged
10 tasks
@c0deaddict c0deaddict closed this Oct 23, 2020
@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Oct 23, 2020 •
edited

You could have just repurposed this PR by changing the title and force pushing.

Nvm I thought the same person opened the new PR.

@c0deaddict
Copy link
Member Author

I closed this because it is superseded by another PR that is not mine: #101049

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
2.status: merge conflict 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@c0deaddict @Emantor @SuperSandro2000 @ryantm