Skip to content
This repository has been archived by the owner on Oct 30, 2020. It is now read-only.

analysis-core is end-of-life #23

Closed
uhafner opened this issue Jul 16, 2020 · 7 comments · Fixed by #24
Closed

analysis-core is end-of-life #23

uhafner opened this issue Jul 16, 2020 · 7 comments · Fixed by #24

Comments

@uhafner
Copy link
Member

uhafner commented Jul 16, 2020

I'm not sure if you noticed that already: analysis-core reached end-of-life since spring 2019. In order to archive the analysis-core project it is required that you also update your plugin to the successor API of the Warnings Next Generation Plugin. Alternatively, you can copy all classes of analysis-core into your plugin (or take over the ownership of the analysis-core plugin). What do you think?
@presidentbeef
Copy link
Member

I did not know that. Thanks for the heads-up!

I'd prefer updating to the new thing. I will take a look.

@uhafner
Copy link
Member Author

uhafner commented Jul 17, 2020

Typically a static analysis tool just needs to provide a parser now. Everything else is handled by the warnings plugin.

@presidentbeef
Copy link
Member

@uhafner is it easier to add a parser (in here?) or to output JSON with the expected fields?

@uhafner
Copy link
Member Author

uhafner commented Jul 18, 2020

Since you already have a parser, you can simply convert it so that it will produce Issue instances in the analysis-model project. Then file a PR in analysis-model so we can create a parser descriptor in the warnings plugin (that provides some additional information like URL, help text).

@presidentbeef presidentbeef mentioned this issue Aug 31, 2020
Merged
@daniel-beck
Copy link
Member

Brakeman support exists in analysis-model 9.0.0 and newer, integrated into Warnings NG 8.4.2.

@gdelisle
Copy link

Sorry, where is the fix for this issue? It seems like the code has been fixed months ago and the documentation is updated, but the plugin version in the directory still stands at 0.13, no update has appeared in the update center, and the link to download the .hpi is broken. Is this issue fixed or not, and if so how can I update to the fixed version?

@presidentbeef
Copy link
Member

The fix is to use https://plugins.jenkins.io/warnings-ng/ instead. This plugin is no longer maintained. Relevant documentation will be updated.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Switch to Warnings Next Generation Plugin jenkinsci/brakeman-plugin
4 participants
@presidentbeef @uhafner @daniel-beck @gdelisle