firefox: disable LTO by default due to segfaults with wayland #101434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As discussed in NixOS#101429 firefox 82 started crashing when used with wayland. A brief investigation showed that this appears to be rooted within the LTO support that was recently added to the package. For the time being, until someone figures out where the crashes are coming from, we can just disable LTO.
|
I'm building this right now, I'll report back once it's done |
|
I did dig a bit more and it seems like Fedora also started disabling LTO with the release of Firefox82 https://src.fedoraproject.org/rpms/firefox/c/65fabb34c1267a295007bc97b53cedc5a79e4154?branch=master |
artemist
approved these changes
Oct 23, 2020
|
Pining @S-NA as he introduced LTO. Maybe he can have a look at this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
As discussed in #101429 firefox 82 started crashing when used with
wayland. A brief investigation showed that this appears to be rooted
within the LTO support that was recently added to the package. For the
time being, until someone figures out where the crashes are coming from,
we can just disable LTO.
cc @artemist
Things done
sandboxinnix.confon non-NixOS linux)