Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

discordpy: 1.3.4 -> 1.5.1 #101437

Merged
merged 1 commit into from Nov 27, 2020
Merged

discordpy: 1.3.4 -> 1.5.1 #101437

merged 1 commit into from Nov 27, 2020

Conversation

IvarWithoutBones
Copy link
Member

@IvarWithoutBones IvarWithoutBones commented Oct 23, 2020 •
edited

Things done

Updated the package to the latest version, added myself as a maintainer and removed the seemingly unused pynacl call.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 101437 run on x86_64-linux 1

2 packages built:
  • python37Packages.discordpy
  • python38Packages.discordpy

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 101437 run on x86_64-darwin 1

2 packages built:
  • python37Packages.discordpy
  • python38Packages.discordpy

@SuperSandro2000 SuperSandro2000 merged commit cddd4fa into NixOS:master Nov 27, 2020
@IvarWithoutBones IvarWithoutBones deleted the discordpy-update branch November 27, 2020 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@IvarWithoutBones @SuperSandro2000