Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ptcollab: init at 0.3.4.1 #101446

Merged
merged 1 commit into from Nov 3, 2020
Merged

ptcollab: init at 0.3.4.1 #101446

merged 1 commit into from Nov 3, 2020

Conversation

OPNA2608
Copy link
Contributor

@OPNA2608 OPNA2608 commented Oct 23, 2020 •
edited

Motivation for this change

FOSS music tracker packaging, cc @fgaz

Adding ptcollab: a music editor for the pxtone format with the capability of collaborative editing over the network. Basically Drawpile but for music.

Packaged here is the latest commit instead of the latest release due to yuxshao/ptcollab#3 adding various install-time improvements. Bumped to version 0.3.4.1.

Tested on NixOS & Ubuntu, including the networking part. Darwin is supported upstream, but needs Qt5.15 afaict which we're currently lacking on that platform. I hence marked it broken on Darwin - or would marking it broken for something like lib.strings.versionOlder qtbase.version "5.15.0" be the better approach here?

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@OPNA2608 OPNA2608 mentioned this pull request Oct 23, 2020
Open
85 tasks
fgaz
fgaz approved these changes Oct 24, 2020
View reviewed changes
Copy link
Member

@fgaz fgaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and the program runs

I'm not sure about broken: isDarwin is simpler, but requires to check it the new qt landed every now and then. But I guess both are fine.

@OPNA2608 OPNA2608 force-pushed the package/ptcollab/21.03 branch 2 times, most recently from ad68ef1 to 853975f Compare October 24, 2020 13:49
@OPNA2608
Copy link
Contributor Author

OPNA2608 commented Nov 3, 2020

Bumped to version 0.3.4.1.

@OPNA2608 OPNA2608 changed the title ptcollab: init at unstable-2020-10-20 ptcollab: init at 0.3.4.1 Nov 3, 2020
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/276

@kevincox kevincox merged commit c4a2a45 into NixOS:master Nov 3, 2020
@OPNA2608 OPNA2608 deleted the package/ptcollab/21.03 branch September 27, 2022 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fgaz fgaz fgaz approved these changes

@zowoq zowoq zowoq left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@OPNA2608 @nixos-discourse @fgaz @zowoq @kevincox