Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pdal: 2.1.0 -> 2.2.0 #101432

Merged
merged 1 commit into from Oct 23, 2020
Merged

pdal: 2.1.0 -> 2.2.0 #101432

merged 1 commit into from Oct 23, 2020

Conversation

nh2
Copy link
Contributor

@nh2 nh2 commented Oct 23, 2020

Motivation for this change

https://github.com/PDAL/PDAL/releases/tag/2.2.0

Changelog items are benign.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@nh2
Copy link
Contributor Author

nh2 commented Oct 23, 2020

@GrahamcOfBorg build cloudcompare

@nh2
Copy link
Contributor Author

nh2 commented Oct 23, 2020

CloudCompare builds fine for me.

@sikmir
Copy link
Member

sikmir commented Oct 23, 2020

https://github.com/PDAL/PDAL/releases/tag/2.2.0:

The Zstandard compression library is no longer required in order to build PDAL.

@nh2
Copy link
Contributor Author

nh2 commented Oct 23, 2020

The Zstandard compression library is no longer required in order to build PDAL.

@sikmir This makes no difference for us; it is now optional upstream but we still want it to have zstd support.

@nh2
Copy link
Contributor Author

nh2 commented Oct 23, 2020

ofborg built CloudCompare successfully, merging.

@nh2 nh2 merged commit 036a415 into NixOS:master Oct 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nh2 @sikmir