Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

terragrunt: 0.25.4 -> 0.25.5 #101448

Merged
merged 3 commits into from Oct 24, 2020
Merged

terragrunt: 0.25.4 -> 0.25.5 #101448

merged 3 commits into from Oct 24, 2020

Conversation

06kellyjac
Copy link
Member

@06kellyjac 06kellyjac commented Oct 23, 2020 •
edited

Motivation for this change
  • remove stdenv (used for stdenv.lib) because we already have lib
  • add myself as a maintainer
  • bump terragrunt version to 0.25.5
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS (x86_64)
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@06kellyjac
terragrunt: clean and sort arguments
200bf0a 
lib was already imported so no need for stdenv.lib
sorted arguments into order of use
@06kellyjac
terragrunt: add jk as a maintainer
268f511 
Add jk (myself) as a maintainer for terragrunt
@06kellyjac
terragrunt: 0.25.4 -> 0.25.5
10c152c
@06kellyjac
Copy link
Member Author

Result of nixpkgs-review pr 101448 1

1 package built:
  • terragrunt

@ofborg ofborg bot requested review from kalbasit and peterhoeg October 23, 2020 09:04
@endocrimes
Copy link
Member

Result of nixpkgs-review pr 101448 1

1 package built:
  • terragrunt

endocrimes
endocrimes approved these changes Oct 24, 2020
View reviewed changes
Copy link
Member

@endocrimes endocrimes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works on my machine - and the lib cleanup is a nice improvement to the package

@06kellyjac
Copy link
Member Author

Thanks for the review @endocrimes
If you're interested you can post to this Discourse thread of already reviewed PRs https://discourse.nixos.org/t/prs-already-reviewed/2617
Not sure what the protocol is with posting something that someone else has reviewed but I can post it in your stead if you'd prefer.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/261

@marsam marsam merged commit 002c634 into NixOS:master Oct 24, 2020
@06kellyjac 06kellyjac deleted the terragrunt_0.25.5 branch October 24, 2020 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@endocrimes endocrimes endocrimes approved these changes

@kalbasit kalbasit Awaiting requested review from kalbasit

@peterhoeg peterhoeg Awaiting requested review from peterhoeg

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@06kellyjac @endocrimes @nixos-discourse @marsam