Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fzf: 0.24.0 -> 0.24.1 #101982

Merged
merged 1 commit into from Oct 29, 2020
Merged

fzf: 0.24.0 -> 0.24.1 #101982

merged 1 commit into from Oct 29, 2020

Conversation

zowoq
Copy link
Contributor

@zowoq zowoq commented Oct 28, 2020

https://github.com/junegunn/fzf/releases/tag/0.24.1

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from kalbasit and Ma27 October 28, 2020 23:10
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 101982 run on x86_64-darwin 1

1 package marked as broken and skipped:
  • fontpreview
7 packages built:
  • fzf
  • fzf-zsh
  • haskellPackages.neuron
  • navi
  • neuron-notes
  • xmloscopy
  • zoxide

@marsam marsam merged commit 392e56b into NixOS:master Oct 29, 2020
@zowoq zowoq deleted the fzf branch October 29, 2020 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalbasit kalbasit Awaiting requested review from kalbasit

@Ma27 Ma27 Awaiting requested review from Ma27

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zowoq @SuperSandro2000 @marsam