Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

img-cat: init at 1.2.0 #101937

Merged
merged 1 commit into from Dec 8, 2020
Merged

img-cat: init at 1.2.0 #101937

merged 1 commit into from Dec 8, 2020

Conversation

penguwin
Copy link
Member

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from kalbasit October 28, 2020 14:52
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 101937 1 run on x86_64-darwin

1 package built:
  • img-cat

@penguwin penguwin requested a review from sikmir October 30, 2020 16:36
@penguwin penguwin changed the title img-cat: init at 1.1.1 img-cat: init at 1.2.0 Nov 12, 2020
@penguwin penguwin requested a review from sikmir November 12, 2020 14:26
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 101937 run on x86_64-linux 1

1 package built:
  • img-cat

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 101937 run on x86_64-linux 1

1 package built:
  • img-cat

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 101937 run on x86_64-darwin 1

1 package built:
  • img-cat

@SuperSandro2000 SuperSandro2000 merged commit 4085eec into NixOS:master Dec 8, 2020
@penguwin penguwin deleted the img-cat branch December 8, 2020 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@sikmir sikmir sikmir approved these changes

@IvarWithoutBones IvarWithoutBones IvarWithoutBones approved these changes

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@penguwin @SuperSandro2000 @sikmir @IvarWithoutBones