Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gallery-dl: 1.15.1 -> 1.15.2 #101977

Merged
merged 2 commits into from Oct 29, 2020
Merged

gallery-dl: 1.15.1 -> 1.15.2 #101977

merged 2 commits into from Oct 29, 2020

Conversation

dawidsowa
Copy link
Contributor

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Oct 28, 2020

Result of nixpkgs-review pr 101977 run on x86_64-darwin 1

1 package failed to build:
  • gallery-dl
        TestDownloaderBase.setUpClass()
        cls.downloader = downloader.find("http")(cls.job)

        port = 8088
        cls.address = "http://127.0.0.1:{}".format(port)
        cls._jpg = cls.address + "/image.jpg"
        cls._png = cls.address + "/image.png"
        cls._gif = cls.address + "/image.gif"

>       server = http.server.HTTPServer(("", port), HttpRequestHandler)

test/test_downloader.py:179:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
/nix/store/65gmh01007csxmd6bbkvas8zkhlw0k7n-python3-3.8.6/lib/python3.8/socketserver.py:452: in __init__
    self.server_bind()
/nix/store/65gmh01007csxmd6bbkvas8zkhlw0k7n-python3-3.8.6/lib/python3.8/http/server.py:138: in server_bind
    socketserver.TCPServer.server_bind(self)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _

self = <http.server.HTTPServer object at 0x10d31e8b0>

    def server_bind(self):
        """Called by constructor to bind the socket.

        May be overridden.

        """
        if self.allow_reuse_address:
            self.socket.setsockopt(socket.SOL_SOCKET, socket.SO_REUSEADDR, 1)
>       self.socket.bind(self.server_address)
E       PermissionError: [Errno 1] Operation not permitted

/nix/store/65gmh01007csxmd6bbkvas8zkhlw0k7n-python3-3.8.6/lib/python3.8/socketserver.py:466: PermissionError
=========================== short test summary info ============================
ERROR test/test_downloader.py::TestHTTPDownloader::test_http_adjust_extension
ERROR test/test_downloader.py::TestHTTPDownloader::test_http_download - Permi...
ERROR test/test_downloader.py::TestHTTPDownloader::test_http_extension - Perm...
ERROR test/test_downloader.py::TestHTTPDownloader::test_http_filesize_max - P...
ERROR test/test_downloader.py::TestHTTPDownloader::test_http_filesize_min - P...
ERROR test/test_downloader.py::TestHTTPDownloader::test_http_offset - Permiss...
=================== 130 passed, 3 skipped, 6 errors in 3.21s ===================

Just remove the test file rm test/test_downloader.py.

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 101977 run on x86_64-darwin 1

1 package built:
  • gallery-dl

@marsam marsam merged commit c69407d into NixOS:master Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants