Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pcb2gcode: init at 2.1.0 #101976

Merged
merged 2 commits into from Jan 26, 2021
Merged

pcb2gcode: init at 2.1.0 #101976

merged 2 commits into from Jan 26, 2021

Conversation

Kritnich
Copy link
Contributor

Motivation for this change

pcb2gcode is a command-line software for the isolation, routing and drilling of PCBs.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SuperSandro2000
Copy link
Member

@Kritnich Can you solve the merge conflict?

SuperSandro2000
SuperSandro2000 requested changes Oct 28, 2020
View reviewed changes
pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved
@SuperSandro2000
Copy link
Member

Can you please squash those commit together?

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 101976 run on x86_64-linux 1

1 package failed to build:
  • pcb2gcode

@Kritnich
Copy link
Contributor Author

Result of nixpkgs-review pr 101976 run on x86_64-linux 1
1 package failed to build:

* pcb2gcode

I ran that as well and it built on x86_64-linux. Do you have any more details on why it failed?

@SuperSandro2000
Copy link
Member 

Can't exec "/bin/sh": No such file or directory at /nix/store/r8b9z1s0di4c8qnhwrpcir7p7rm7s4x7-autoconf-2.69/share/autoconf/Autom4te/General.pm line 307.
Use of uninitialized value $Autom4te::General::tmp in scalar chomp at /nix/store/r8b9z1s0di4c8qnhwrpcir7p7rm7s4x7-autoconf-2.69/share/autoconf/Autom4te/General.pm line 309.
Can't exec "/bin/sh": No such file or directory at /nix/store/r8b9z1s0di4c8qnhwrpcir7p7rm7s4x7-autoconf-2.69/bin/autoreconf line 188.
Can't exec "/bin/sh": No such file or directory at /nix/store/r8b9z1s0di4c8qnhwrpcir7p7rm7s4x7-autoconf-2.69/bin/autoreconf line 189.
Use of uninitialized value $aclocal_help in pattern match (m//) at /nix/store/r8b9z1s0di4c8qnhwrpcir7p7rm7s4x7-autoconf-2.69/bin/autoreconf line 190.
Use of uninitialized value $aclocal_help in pattern match (m//) at /nix/store/r8b9z1s0di4c8qnhwrpcir7p7rm7s4x7-autoconf-2.69/bin/autoreconf line 191.
Use of uninitialized value $automake_help in pattern match (m//) at /nix/store/r8b9z1s0di4c8qnhwrpcir7p7rm7s4x7-autoconf-2.69/bin/autoreconf line 192.
Use of uninitialized value $automake_help in pattern match (m//) at /nix/store/r8b9z1s0di4c8qnhwrpcir7p7rm7s4x7-autoconf-2.69/bin/autoreconf line 193.
autoreconf: Entering directory `.'
autoreconf: configure.ac: not using Gettext
autoreconf: running: aclocal -I m4 --output=aclocal.m4t
Can't exec "/bin/sh": No such file or directory at /nix/store/38vxlxrvg3yji3jms44qn94lxdysbj5j-perl-5.32.0/lib/perl5/5.32.0/x86_64-linux-thread-multi/IO/File.pm line 186.
aclocal: error: cannot open echo 'm4_define([m4_require_silent_probe], [-])' | /nix/store/r8b9z1s0di4c8qnhwrpcir7p7rm7s4x7-autoconf-2.69/bin/autom4te --language Autoconf-without-aclocal-m4  - /nix/store/ldr8z2

@Kritnich
Copy link
Contributor Author

Kritnich commented Nov 1, 2020

I have been unable to reproduce the issue on two different machines, but I assume it has something to do with bash and a missing symlink to it on /bin/sh. If it still doesn't work, do you have any pointers on how I can reproduce the issue?

@SuperSandro2000
Copy link
Member

I opened /nix/store/r8b9z1s0di4c8qnhwrpcir7p7rm7s4x7-autoconf-2.69/share/autoconf/Autom4te/General.pm +307 locally:

image

and the error message might be miss leading. It could be that it tries to access /tmp which is disabled in sandbox mode I believe. I think setting $TMPDIR correct could solve the issue. Or it is the ` but then I ask myself how any perl code works.

Lastly it might also be a quirk with my machines I did not discover yet.

@Kritnich
Copy link
Contributor Author

Kritnich commented Nov 7, 2020

TMPDIR should be set correctly by mkDerivation whether it's sandboxed or not (to /tmp or /build), if I understood it correctly.

Besides that, both machines I tested it on were in sandbox mode and in /nix/store/r8b9z1s0di4c8qnhwrpcir7p7rm7s4x7-autoconf-2.69/bin/autoreconf at L188,L189 there's the same issue with backticks present but no /tmp being used.

Definitely seems to me like Perl is trying to call /bin/sh -c but fails because it's missing, which is odd since I feel like that should break way more.

Either way, I included bash in that last push. Can you give it a shot and see if it builds on your machine now?

@fooker
Copy link
Contributor

fooker commented Nov 11, 2020

I've tested it with the latest commit and it worked well. Both, building and executing the resulting command.

SuperSandro2000
SuperSandro2000 requested changes Nov 24, 2020
View reviewed changes
pkgs/tools/misc/pcb2gcode/default.nix Outdated Show resolved Hide resolved
pkgs/tools/misc/pcb2gcode/default.nix Outdated Show resolved Hide resolved
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 101976 run on x86_64-linux 1

1 package built:
  • pcb2gcode

@Kritnich Kritnich force-pushed the pcb2gcode-2.1.0 branch 2 times, most recently from f0fecf0 to 027ba9d Compare November 25, 2020 17:38
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 101976 run on x86_64-linux 1

1 package built:
  • pcb2gcode

@SuperSandro2000
Copy link
Member

@Kritnich please address #101976 (comment)

SuperSandro2000
SuperSandro2000 requested changes Dec 27, 2020
View reviewed changes
pkgs/tools/misc/pcb2gcode/default.nix Outdated Show resolved Hide resolved
pkgs/tools/misc/pcb2gcode/default.nix Outdated Show resolved Hide resolved
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 101976 run on x86_64-linux 1

1 package built:
  • pcb2gcode

SuperSandro2000
SuperSandro2000 requested changes Jan 24, 2021
View reviewed changes
pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved
pkgs/tools/misc/pcb2gcode/default.nix Outdated Show resolved Hide resolved
pkgs/tools/misc/pcb2gcode/default.nix Outdated Show resolved Hide resolved
@SuperSandro2000 SuperSandro2000 merged commit d06bae4 into NixOS:master Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 requested changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Kritnich @SuperSandro2000 @fooker @Janik-Haag