Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libtensorflow-bin: unmark as broken #101950

Merged
merged 1 commit into from Oct 28, 2020
Merged

libtensorflow-bin: unmark as broken #101950

merged 1 commit into from Oct 28, 2020

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Oct 28, 2020 •
edited

Motivation for this change

Accidentally marked it broken when marking the tensorflow python packages as broken

context: #101863 (comment)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@andir
Copy link
Member

andir commented Oct 28, 2020

Nit: libtensorflow-bin is the right package name for the commit message.

Thank you for doing this. Was about to open this PR myself :)

andir
andir approved these changes Oct 28, 2020
View reviewed changes
Copy link
Member

@andir andir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as long as we fix the commit message.

@jonringer jonringer changed the title libtensorflow: unmark as broken libtensorflow-bin: unmark as broken Oct 28, 2020
@jonringer
Copy link
Contributor Author

just waiting on ofborg

@jonringer jonringer merged commit 229fade into NixOS:release-20.09 Oct 28, 2020
@jonringer jonringer deleted the unbreak-libtensor branch October 28, 2020 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andir andir andir approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonringer @andir