Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnomeExtensions.clipboard-indicator: 34 -> 37 #101939

Merged
merged 1 commit into from Nov 13, 2020
Merged

gnomeExtensions.clipboard-indicator: 34 -> 37 #101939

merged 1 commit into from Nov 13, 2020

Conversation

jonafato
Copy link
Contributor

Motivation for this change

clipboard-indicator has a new release. Most notably, this adds support
for GNOME 3.38 and drops support for 3.36 (note that while the extension
no longer lists 3.36 as a supported version, it does still work).

Full changelog

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jonafato
gnomeExtensions.clipboard-indicator: 34 -> 37
3c122da 
clipboard-indicator has a new release. Most notably, this adds support
for GNOME 3.38 and drops support for 3.36 (note that while the extension
no longer lists 3.36 as a supported version, it does still work).

[Full changelog](Tudmotu/gnome-shell-extension-clipboard-indicator@v34...v37)
@jonafato
Copy link
Contributor Author

@NixOS/gnome Now that 3.38 is on master, can I get a review on this update? The extension is broken on 3.38 without this version bump.

@jtojnar
Copy link
Contributor

jtojnar commented Nov 13, 2020

Changes look fine to me.

@jtojnar jtojnar merged commit cb0be69 into NixOS:master Nov 13, 2020
@jonafato jonafato deleted the gnome-shell-extension-clipboard-indicator-37 branch November 13, 2020 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: GNOME GNOME desktop environment and its underlying platform 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonafato @jtojnar