Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[staging] hidapi: 0.9.0 -> 0.10.0 #101934

Merged
merged 2 commits into from Nov 1, 2020
Merged

[staging] hidapi: 0.9.0 -> 0.10.0 #101934

merged 2 commits into from Nov 1, 2020

Conversation

prusnak
Copy link
Member

@prusnak prusnak commented Oct 28, 2020 •
edited

Motivation for this change

Version update (+version update of Python binding)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from np October 28, 2020 14:06
@prusnak prusnak changed the base branch from master to staging October 28, 2020 14:28
@ofborg ofborg bot added 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: haskell 6.topic: nixos 6.topic: pantheon The Pantheon desktop environment 6.topic: ruby 6.topic: rust 6.topic: stdenv Standard environment 8.has: changelog 8.has: documentation 8.has: module (update) and removed 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: haskell labels Oct 28, 2020
@mweinelt
Copy link
Member

Version update (+version update of Python binding)

I only see the python bindings update.

@prusnak
Copy link
Member Author

prusnak commented Oct 29, 2020

I only see the python bindings update.

Sorry about that, I dropped that commit by accident while rebasing. It's back now.

@mweinelt mweinelt changed the title hidapi: 0.9.0 -> 0.10.0 [staging] hidapi: 0.9.0 -> 0.10.0 Oct 29, 2020
@FRidh FRidh merged commit b9222f5 into NixOS:staging Nov 1, 2020
@prusnak prusnak deleted the hidapi branch December 3, 2020 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@np np Awaiting requested review from np

@alyssais alyssais Awaiting requested review from alyssais

@cdepillabout cdepillabout Awaiting requested review from cdepillabout

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314

@LnL7 LnL7 Awaiting requested review from LnL7

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

@Mic92 Mic92 Awaiting requested review from Mic92

@zowoq zowoq Awaiting requested review from zowoq

Assignees
No one assigned
Labels
6.topic: python 8.has: clean-up 8.has: package (new) 10.rebuild-darwin: 501+ 10.rebuild-darwin: 1001-2500 10.rebuild-linux: 501+ 10.rebuild-linux: 2501-5000 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@prusnak @mweinelt @FRidh