Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

piglit: init at unstable-2020-10-28 #101941

Merged
merged 2 commits into from Nov 5, 2020
Merged

piglit: init at unstable-2020-10-28 #101941

merged 2 commits into from Nov 5, 2020

Conversation

Flakebi
Copy link
Member

@Flakebi Flakebi commented Oct 28, 2020 •
edited

Motivation for this change

Piglit is a test runner for mesa.
waffle is a dependency for piglit.

To check if everything is working: piglit run sanity results/sanity

cc @danieldk

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Oct 28, 2020 •
edited

Result of nixpkgs-review pr 101941 1 run on x86_64-darwin

@ofborg Why did you put the darwin label on this?

@Flakebi Flakebi force-pushed the waffle branch 2 times, most recently from e94bdc0 to c6331f1 Compare October 28, 2020 16:01
danieldk
danieldk suggested changes Nov 2, 2020
View reviewed changes
Copy link
Contributor

@danieldk danieldk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! A first stab at a review (I have to look at the package in a bit more detail).

I also noticed while compiling that CMake complains about libffi and pthread-stubs missing. Are these necessary?

pkgs/development/libraries/waffle/default.nix Outdated Show resolved Hide resolved
pkgs/tools/graphics/piglit/default.nix Outdated Show resolved Hide resolved
pkgs/tools/graphics/piglit/default.nix Outdated Show resolved Hide resolved
pkgs/tools/graphics/piglit/default.nix Outdated Show resolved Hide resolved
pkgs/tools/graphics/piglit/default.nix Outdated Show resolved Hide resolved
pkgs/tools/graphics/piglit/default.nix Outdated Show resolved Hide resolved
@Flakebi
waffle: init at 1.6.1
156fe54
@Flakebi
piglit: init at unstable-2020-10-23
2907f28 
piglit is a test runner for mesa.
To check that it is working, run `piglit run sanity results/sanity`
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 101941 run on x86_64-linux 1

2 packages built:
  • piglit
  • waffle

@danieldk danieldk merged commit 820f3be into NixOS:master Nov 5, 2020
@Flakebi Flakebi deleted the waffle branch November 5, 2020 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sikmir sikmir sikmir left review comments

@danieldk danieldk danieldk approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Flakebi @SuperSandro2000 @danieldk @sikmir