home-assistant: 0.116.4 -> 0.117.0 (+ additional package updates) #101968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests require network access.
Also clean up the package and enable tests.
Clean up package and convert tests to pytestCheckHook.
|
@GrahamcOfBorg test home-assistant |
jonringer
reviewed
Oct 28, 2020
Comment on lines
+21
to
23
| version = "0.16.1"; | ||
| disabled = pythonOlder "3.6"; | ||
|
|
There was a problem hiding this comment.
looks like a regression:
builder for '/nix/store/667gj5w9jcysm7pad0b4lma5hv4zkggf-python3.7-asgi-csrf-0.7.drv' failed with exit code 2; last 10 log lines:
ImportError while importing test module '/build/source/test_asgi_csrf.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
test_asgi_csrf.py:7: in <module>
from httpx._content_streams import MultipartStream
E ModuleNotFoundError: No module named 'httpx._content_streams'
=========================== short test summary info ============================
ERROR test_asgi_csrf.py
!!!!!!!!!!!!!!!!!!!! Interrupted: 1 error during collection !!!!!!!!!!!!!!!!!!!!
=============================== 1 error in 0.15s ===============================
cannot build derivation '/nix/store/hda4799m3wcb5mfazk2x1s77i0v8qykr-python3.7-datasette-0.46.drv': 1 dependencies couldn't be built
There was a problem hiding this comment.
Probably related to encode/httpx@354c4ca.
There was a problem hiding this comment.
Reported in simonw/asgi-csrf#18.
There was a problem hiding this comment.
looks like they imported a private module... so shame on them
There was a problem hiding this comment.
maybe just disable that test?
Doesn't look like it's failing on anything exported by the module
There was a problem hiding this comment.
Disabled the tests on asgi-csrf and bumped the package to the latest version for good measure.
10 tasks
|
everything else passes: |
The packages tests import a private module from httpx, that does not exist anymore in newer versions.
|
Result of 15 packages built:
|
jonringer
approved these changes
Oct 29, 2020
There was a problem hiding this comment.
LGTM
Result of nixpkgs-review pr 101968 1
15 packages built:
- datasette (python38Packages.datasette)
- google-music-scripts
- home-assistant
- python27Packages.spotipy
- python37Packages.asgi-csrf
- python37Packages.datasette
- python37Packages.google-music
- python37Packages.httpcore
- python37Packages.httpx
- python37Packages.spotipy
- python38Packages.asgi-csrf
- python38Packages.google-music
- python38Packages.httpcore
- python38Packages.httpx
- python38Packages.spotipy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
New upstream release. Also update and clean up dependencies.
https://github.com/home-assistant/core/releases
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)