@SuperSandro2000 thanks for the quick feedback, updated.

Result of nixpkgs-review pr 101947 1 run on x86_64-darwin

@sikmir Updated, thanks for the feedback.

I think everything is ready here, can this be merged? 😄

Also please squash the review related commits into the init ones.

One test is failing:

[       OK ] SndFileAudioFileReaderTest.shouldNotProcessFileMoreThanOnce (1 ms)
[ RUN      ] SndFileAudioFileReaderTest.shouldReportErrorIfNotAWavFile
/build/source/test/SndFileAudioFileReaderTest.cpp:316: Failure
Value of: error.str()
Expected: is equal to "Failed to read file: ../test/data/test_file_stereo.mp3\nFile contains data in an unknown format.\n"
  Actual: "Failed to read file: ../test/data/test_file_stereo.mp3\nFormat not recognised.\n"
[  FAILED  ] SndFileAudioFileReaderTest.shouldReportErrorIfNotAWavFile (0 ms)
[----------] 10 tests from SndFileAudioFileReaderTest (5 ms total)

@SuperSandro2000 How are you running the tests? When I run nix-build -A audiowaveform it shows as passed to me?

Running tests...
/nix/store/z7qvx6wbvmjvs767g06h03pkzr5aqn6i-cmake-3.18.2/bin/ctest --force-new-ctest-process
Test project /private/var/folders/bh/4nbf2dn14wn3ztnrbrqn11l80000gn/T/nix-build-audiowaveform-1.4.2.drv-0/source/build
    Start 1: audiowaveform_tests
1/1 Test #1: audiowaveform_tests ..............   Passed    6.03 sec

100% tests passed, 0 tests failed out of 1

Result of nixpkgs-review pr 101947 run on x86_64-linux 1

Failed test

I run nixpkgs-review pr 101947.

Thanks, reproduced locally now. So the failing test is the error message should say "File contains data in an unknown format" but instead says "Format not recognised"...

I'm not sure where that error originates from but I don't see it mentioned in the codebase, so perhaps a dependency. I'm not an original contributor to audiowaveform so I wouldn't know where to start on correcting this test. If the tests can be disabled I can progress, otherwise I think this is as far as I can reasonably get here on my own.

If the tests can be disabled I can progress, otherwise I think this is as far as I can reasonably get here on my own.

Yeah, you can just disable the tests or preferable the one test.

Result of nixpkgs-review pr 101947 run on x86_64-darwin 1

Result of nixpkgs-review pr 101947 run on x86_64-linux 1

/build/source/test/SndFileAudioFileReaderTest.cpp:316: Failure
Value of: error.str()
Expected: is equal to "Failed to read file: ../test/data/test_file_stereo.mp3\nFile contains data in an unknown format.\n"
  Actual: "Failed to read file: ../test/data/test_file_stereo.mp3\nFormat not recognised.\n"
  [  FAILED  ] SndFileAudioFileReaderTest.shouldReportErrorIfNotAWavFile (0 ms)

Tests have been disabled (added a comment on why) and I've squashed the commits.

Result of nixpkgs-review pr 101947 run on x86_64-darwin 1

Result of nixpkgs-review pr 101947 run on x86_64-linux 1