Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nodePackages.fauna-shell: init at 0.11.5 #101217

Merged
merged 1 commit into from Nov 4, 2020
Merged

nodePackages.fauna-shell: init at 0.11.5 #101217

merged 1 commit into from Nov 4, 2020

Conversation

hardselius
Copy link
Contributor

Motivation for this change

I need fauna-shell. Naturally, as a Nix user, I want to avoid brew or npm install -g. This seemed like a good opportunity to make my first PR to nixpkgs.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from midchildan October 20, 2020 21:43
@hardselius
Copy link
Contributor Author

hardselius commented Oct 22, 2020 •
edited

@midchildan Thanks for the approval! What's the lead time (ish) for getting this merged?

@midchildan
Copy link
Member

It's hard to tell. You'd need to get a committer to get this merged, but some PRs get buried because of the sheer number of PRs nixpkgs receives each day. If it's taking more than a few weeks, you might want to drop a comment here: https://discourse.nixos.org/t/prs-already-reviewed/2617/68

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/275

@kevincox
Copy link
Contributor

kevincox commented Nov 3, 2020

Can you resolve the merge conflicts then you can ping me for a merge?

@ofborg ofborg bot requested a review from midchildan November 4, 2020 00:00
@kevincox kevincox merged commit e84d30d into NixOS:master Nov 4, 2020
@hardselius
Copy link
Contributor Author

@kevincox Thanks for the merge! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@midchildan midchildan Awaiting requested review from midchildan

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@hardselius @midchildan @nixos-discourse @kevincox @Janik-Haag