Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

todoist-electron: 1.23.0 -> 1.24.0, update license, use desktop icon #101216

Merged
merged 3 commits into from Nov 27, 2020

Conversation

i077
Copy link
Contributor

@i077 i077 commented Oct 20, 2020

Motivation for this change

Upstream repo added an MIT license. Also copies the icon over to $out so it's used in the .desktop file.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 101216 run on x86_64-linux 1

1 package built:
  • todoist-electron

@SuperSandro2000 SuperSandro2000 merged commit 3b56224 into NixOS:master Nov 27, 2020
@i077 i077 deleted the todoist-electron/1.24 branch November 27, 2020 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants