Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gdal: fix S57 data directory #101200

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

gdal: fix S57 data directory #101200

wants to merge 1 commit into from

Conversation

bgamari
Copy link
Contributor

@bgamari bgamari commented Oct 20, 2020

Motivation for this change

GDAL's S57 driver expects to be able to find various files in its data
directory. Usually this would be located via the S57_CSV environment variable. We obviously don't want to have to set this in every downstream use of GDAL so consequently I instead patch the driver to rather hard-code the path to the data directory.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bgamari
gdal: fix S57 data directory
21edc3b 
GDAL's S57 driver expects [1] to be able to find various files in its data
directory. Fix this location.

[1] https://gdal.org/drivers/vector/s57.html#vector-s57
@bgamari
Copy link
Contributor Author

bgamari commented Oct 20, 2020

Cc @MarcWeber

@SuperSandro2000
Copy link
Member

Does it only write to this directory at build time or also at run time?

@stale
Copy link

stale bot commented Jun 3, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 3, 2021
@r-burns
Copy link
Contributor

r-burns commented Dec 3, 2021

Still interested? This is correct AFAICT, I have a few minor suggestions but I'd be happy to review & merge if you're up for it.

Does it only write to this directory at build time or also at run time?

Only at build-time, it's ok for the files to be read-only at runtime.

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Dec 3, 2021
@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 12, 2022
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Mar 20, 2024
@wegank wegank marked this pull request as draft March 25, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
2.status: merge conflict 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bgamari @SuperSandro2000 @r-burns @wegank